Polyfill: Date.prototype.toTemporalInstant should not be a constructor #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test for this was recently added to test262. Per the spec text, Date.prototype.toTemporalInstant should not be contstructible. However, the previous implementation did allow it to be called as a constructor.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3040 +/- ##
=======================================
Coverage ? 95.70%
=======================================
Files ? 21
Lines ? 9695
Branches ? 1741
=======================================
Hits ? 9279
Misses ? 364
Partials ? 52 ☔ View full report in Codecov by Sentry. |
jasonwilliams
approved these changes
Nov 11, 2024
No, it's because of a change to test262 that's being pulled in along with the test for this polyfill change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates test262 and adds a fix for a newly-added test that the reference code fails.