Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed website section in README #3981

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Fixed website section in README #3981

merged 4 commits into from
Jan 9, 2024

Conversation

Clonex
Copy link
Contributor

@Clonex Clonex commented Jan 5, 2024

Currently it links to a dead page, which is odd.
Let's link to the PR which removed the code, to give the reader some kind of thread to follow.

@Clonex Clonex requested a review from a team as a code owner January 5, 2024 19:43
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but probably a more useful link would be the tree at the last sha before that PR.

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Clonex
Copy link
Contributor Author

Clonex commented Jan 9, 2024

This is fine, but probably a more useful link would be the tree at the last sha before that PR.

Yeah thats a good point, I've updated it 😃

README.md Outdated Show resolved Hide resolved
@Ms2ger Ms2ger enabled auto-merge (squash) January 9, 2024 09:46
@Ms2ger Ms2ger merged commit 211195b into tc39:main Jan 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants