Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for useGrouping off in digital style of DurationFormat #4208

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Add test for useGrouping off in digital style of DurationFormat #4208

merged 2 commits into from
Feb 12, 2025

Conversation

FrankYFTang
Copy link
Contributor

Fix #4190

@FrankYFTang FrankYFTang requested a review from a team as a code owner August 22, 2024 21:55
@FrankYFTang
Copy link
Contributor Author

@anba @ben-allen @ptomato @sffc

@FrankYFTang
Copy link
Contributor Author

@ryzokuken

ptomato
ptomato approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

test/intl402/DurationFormat/prototype/format/style-digital-largenumber-en.js Outdated Show resolved Hide resolved
test/intl402/DurationFormat/prototype/format/style-digital-largenumber-en.js Outdated Show resolved Hide resolved
@ptomato ptomato added awaiting consensus This needs committee consensus before it can be eligible to be merged. awaiting author labels Aug 23, 2024
@FrankYFTang FrankYFTang requested a review from ptomato August 23, 2024 18:56
@FrankYFTang
Copy link
Contributor Author

PTAL

ptomato
ptomato approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptomato
Copy link
Contributor

ptomato commented Jan 31, 2025

#4190 was closed by #4268. Is this still needed?

@ryzokuken
Copy link
Member

This has more test cases but the important case is already accounted for... I think it's fine either way.

@ptomato
Copy link
Contributor

ptomato commented Feb 12, 2025

OK, more test cases seems good.

@ptomato ptomato merged commit 37722d8 into tc39:main Feb 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
awaiting consensus This needs committee consensus before it can be eligible to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need test for intl-duration-format/pull/198
3 participants
@FrankYFTang @ptomato @ryzokuken