Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for "Limit valid values for DurationFormats to match upcoming limits in Temporal" #4254

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

sosukesuzuki
Copy link
Contributor

This PR is just a cherry-pick of the last commit from #3988 to resolve conflicts. Closes #3988.


Update tests for tc39/proposal-intl-duration-format#173.

@sosukesuzuki
Copy link
Contributor Author

@sffc @FrankYFTang @ptomato @anba

I created a new PR that cherry-picks the last commit from #3988 in order to move forward with Intl.DurationFormat. I haven't made any changes to the code, and the license remains the same.

What do you think?

@sosukesuzuki sosukesuzuki marked this pull request as ready for review October 9, 2024 15:35
@sosukesuzuki sosukesuzuki requested a review from a team as a code owner October 9, 2024 15:35
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already reviewed this in #3988, so 👍 from me. Thanks for rebasing it.

@ptomato
Copy link
Contributor

ptomato commented Oct 10, 2024

Let's get this merged, since #3988 was already open for quite a while.

@ptomato ptomato merged commit ab809f8 into tc39:main Oct 10, 2024
8 checks passed
@sosukesuzuki sosukesuzuki deleted the sosuke/duration-format-precision branch October 10, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants