Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/list all events in previous events view #100

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

TorgrimRL
Copy link

No description provided.

    🗃️ Add 15 new past events to seed data for testing
    ✨ Implement /past-events/count endpoint to get the count of past events
    ✨ Implement /past-events endpoint to retrieve past events with pagination
    ✅ Add tests for the two new API endpoints
Copy link
Contributor

@otytlandsvik otytlandsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀 Left some comments that should be fixed

app/api/events.py Outdated Show resolved Hide resolved
app/api/events.py Outdated Show resolved Hide resolved
app/api/events.py Outdated Show resolved Hide resolved
TorgrimRL and others added 6 commits December 13, 2024 11:57
This commit will:
- Refactor the `get_past_events` endpoint to use a fixed query limit
- Now uses localtime instead of utctime in `get_past_events` endpoint
- Refactor the 'get_past_events' endpoint to use the same mongodb-query logic as the rest of the functions for consistency
- Update pagination parameters in the test suite to reflect the new fixed limit and validate functionality.
- Ensure tests verify filtering and pagination logic with updated query constraints.
@otytlandsvik otytlandsvik self-requested a review February 12, 2025 20:30
Copy link
Contributor

@otytlandsvik otytlandsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ready once frontend PR is up to date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants