Make response of web api with handler return data optional #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myTerminal
reviewed
Sep 26, 2020
| res: res | ||
| }); | ||
|
|
||
| if (response) { |
There was a problem hiding this comment.
I don't quite understand the motivation behind this check. How about ignore the response when not required rather than make this response optional?
There was a problem hiding this comment.
There will be times when it will not be a direct returned value that you need to respond to the client, for example when its an async process or when you want to return status codes other than 200.
So this check will see if anything is to be returned, else the called handler function will be responsible to respond.
It may have broken other parts of the code, we will probably need to find a better solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is