feat: 회원 Authorization Grant 받고 페이지 반환 기능 구현 #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
세연님 PR 재등록 후 알려주시기 바랍니다~ |
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Checklist
feat: 유저 조회 기능 구현)🧩 이슈 번호
👩💻 공유 포인트 및 논의 사항
1. Utils
생각보다 Utils가 좀 필요하다 보니, global utils에 클래스를 추가했는데, 저만 사용할 것 같은 util 클래스는 따로 분리할까요? 아님 놔둘까요
2. Enum
Enum에서는
Lombok을 사용하게 된다면,AllArgsConstructor를 사용해야 해서 생성자로 처리했습니다.3. BaseImageUrl
카카오에서 프로필을 가져오면 해당 이미지 url이 있을텐데 그 url을 사용하거나 없으면 S3의 기본 url을 사용할 것 같아서 path만 잡아서 넣어놨습니다.
4. Authorization Code Path
Authorization Code를 받기 위한 redirect_path가 필요한데, 기본 path가
/members여서/members/login/kakao/oauth로 지정했습니다.path가 애매하고 기능이 많다고 느껴져서 controller를 분리할 생각도 하고있는데, 다들 어떻게 생각하시나요?
변경한다면,
AuthController
MemberController
일 것 같습니다.