Merge pull request #584 from team-monite/fix/products-services-error-…

…improvements fix(DEV-14050): Improve error messages in products and services
team-monite · Feb 18, 2025 · 2fe07d1 · 2fe07d1
2 parents 0c0892d + 18df891
commit 2fe07d1
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 6 deletions.
diff --git a/.changeset/serious-games-attack.md b/.changeset/serious-games-attack.md
@@ -0,0 +1,6 @@
+---
+'@monite/sdk-react': patch
+'@monite/sdk-drop-in': patch
+---
+
+Improve error messages in Products&Services component
diff --git a/packages/sdk-react/src/components/products/ProductDetails/validation.ts b/packages/sdk-react/src/components/products/ProductDetails/validation.ts
@@ -32,11 +32,13 @@ export const getValidationSchema = (i18n: I18n) =>
       .required(),
     smallestAmount: yup
       .number()
-      .min(0)
+      .typeError(t(i18n)`Please enter a number`)
+      .min(0, t(i18n)`Minimum quantity must be 0 or greater`)
       .label(t(i18n)`Minimum quantity`)
       .required(),
     pricePerUnit: yup
       .number()
+      .typeError(t(i18n)`Please enter a number`)
       .min(0)
       .label(t(i18n)`Price per unit`)
       .required(),
@@ -45,7 +47,10 @@ export const getValidationSchema = (i18n: I18n) =>
       .oneOf(currenciesToStringArray(getCurrencies(i18n)))
       .label(t(i18n)`Currency`)
       .required(),
-    description: yup.string().label(t(i18n)`Description`),
+    description: yup
+      .string()
+      .max(255)
+      .label(t(i18n)`Description`),
   });
 
 export type IProductFormSubmitValues = yup.InferType<

diff --git a/packages/sdk-react/src/core/i18n/locales/en/messages.po b/packages/sdk-react/src/core/i18n/locales/en/messages.po
@@ -2095,7 +2095,7 @@ msgstr "Cuba"
 #: src/components/onboarding/OnboardingBankAccount/OnboardingBankAccount.tsx:58
 #: src/components/onboarding/validators/validationSchemas.ts:116
 #: src/components/payables/PayableDetails/PayableDetailsForm/PayableDetailsForm.tsx:137
-#: src/components/products/ProductDetails/validation.ts:46
+#: src/components/products/ProductDetails/validation.ts:48
 #: src/components/receivables/InvoiceDetails/CreateReceivable/validation.ts:13
 #: src/components/receivables/InvoiceDetails/CreateReceivable/validation.ts:85
 #: src/ui/Currency/MoniteCurrency.tsx:51
@@ -2355,7 +2355,7 @@ msgstr "Department Stores"
 #: src/components/approvalPolicies/ApprovalPolicyDetails/ExistingApprovalPolicyDetailsAdvanced/ExistingApprovalPolicyDetailsAdvanced.tsx:84
 #: src/components/products/ProductDetails/components/ProductForm/ProductForm.tsx:97
 #: src/components/products/ProductDetails/ExistingProductDetails.tsx:165
-#: src/components/products/ProductDetails/validation.ts:48
+#: src/components/products/ProductDetails/validation.ts:53
 #: src/components/receivables/InvoiceDetails/CreateReceivable/sections/components/PaymentTerms/PaymentTermsForm.tsx:165
 msgid "Description"
 msgstr "Description"
@@ -4394,10 +4394,14 @@ msgstr "Minimum number of approvals required"
 
 #: src/components/products/ProductDetails/components/ProductForm/ProductForm.tsx:160
 #: src/components/products/ProductDetails/ExistingProductDetails.tsx:185
-#: src/components/products/ProductDetails/validation.ts:36
+#: src/components/products/ProductDetails/validation.ts:37
 msgid "Minimum quantity"
 msgstr "Minimum quantity"
 
+#: src/components/products/ProductDetails/validation.ts:36
+msgid "Minimum quantity must be 0 or greater"
+msgstr "Minimum quantity must be 0 or greater"
+
 #: src/components/onboarding/dicts/mccCodes.ts:884
 msgid "Miscellaneous Apparel and Accessory Shops"
 msgstr "Miscellaneous Apparel and Accessory Shops"
@@ -5315,6 +5319,11 @@ msgstr "Please add any individual who owns 25% or more of your business."
 msgid "Please correct the errors in persons information."
 msgstr "Please correct the errors in persons information."
 
+#: src/components/products/ProductDetails/validation.ts:35
+#: src/components/products/ProductDetails/validation.ts:41
+msgid "Please enter a number"
+msgstr "Please enter a number"
+
 #: src/components/onboarding/validators/validators.ts:139
 msgid "Please enter a phone number."
 msgstr "Please enter a phone number."
@@ -5475,7 +5484,7 @@ msgstr "Price"
 
 #: src/components/products/ProductDetails/components/ProductForm/ProductForm.tsx:174
 #: src/components/products/ProductDetails/ExistingProductDetails.tsx:189
-#: src/components/products/ProductDetails/validation.ts:41
+#: src/components/products/ProductDetails/validation.ts:43
 #: src/components/products/ProductsTable/ProductsTable.tsx:212
 msgid "Price per unit"
 msgstr "Price per unit"