Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proposal): highest vat default, autocomplete padding, reminders grid, border and size quantity items #590

Merged
merged 10 commits into from
Feb 21, 2025

Conversation

cristinafrombr
Copy link
Collaborator

@cristinafrombr cristinafrombr commented Feb 19, 2025

Improvements requested during design sync on 19.2, or in the slack channel.

  • Highest vat rate now chosen by default when selecting items.

  • Decrease number of clicks in create counterpart modal (remove buttons from first step).
    Screenshot 2025-02-20 001446

  • In the same modal, added back button that returns to first step. I will add an arrow to it later.
    Screenshot 2025-02-20 012839

  • There was a double border during focus state in quantity field. I removed the black border and kept only the blue-purple to keep consistent with the rest of the page. I also decreased the size of the quantity column and removed the gray border as requested by designers.
    Small screen:
    Screenshot 2025-02-19 214752
    Hover before:
    Screenshot 2025-02-19 233300
    Hover after:
    Screenshot 2025-02-19 233221
    Screenshot 2025-02-19 233855

  • Different text alignment for the last columns to better distribute the values while we don't have amount and discount columns.
    Screenshot 2025-02-19 231002
    Screenshot 2025-02-20 000501

  • Fixed misalignments and grid in reminders' section. Large screen:
    Screenshot 2025-02-20 000136
    Small screen:
    Screenshot 2025-02-20 000453

Additionally I fix the padding in currency selection of items dialogue. The padding was set on 0 to the left on purpose, so I presume this is required somewhere else. The "somewhere else" probably needs a more specific rule. Let me know if I could assist on that.
before:
Screenshot 2025-02-20 000827
after:
Screenshot 2025-02-20 001041

  • Tax rate shown in multiple rows when needed. Please notice different behaviors in screenshots below.
    Screenshot 2025-02-20 221642
    Screenshot 2025-02-20 221620
    Screenshot 2025-02-20 221629

Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: a0e1743

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@monite/sdk-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cristinafrombr cristinafrombr changed the title fix highest vat default, autocomplete padding, reminders grid, border and size quantity items fix(dev) highest vat default, autocomplete padding, reminders grid, border and size quantity items Feb 19, 2025
@cristinafrombr cristinafrombr changed the title fix(dev) highest vat default, autocomplete padding, reminders grid, border and size quantity items fix(dev): highest vat default, autocomplete padding, reminders grid, border and size quantity items Feb 19, 2025
@cristinafrombr cristinafrombr marked this pull request as ready for review February 19, 2025 23:47
@cristinafrombr cristinafrombr changed the title fix(dev): highest vat default, autocomplete padding, reminders grid, border and size quantity items fix(DEV-): highest vat default, autocomplete padding, reminders grid, border and size quantity items Feb 19, 2025
@marcperezmonite marcperezmonite changed the title fix(DEV-): highest vat default, autocomplete padding, reminders grid, border and size quantity items fix(proposal): highest vat default, autocomplete padding, reminders grid, border and size quantity items Feb 20, 2025
@marcperezmonite marcperezmonite merged commit 3422ccb into main Feb 21, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants