-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(proposal): highest vat default, autocomplete padding, reminders grid, border and size quantity items #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and size quantity items
🦋 Changeset detectedLatest commit: a0e1743 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cristinafrombr
commented
Feb 19, 2025
...omponents/receivables/InvoiceDetails/CreateReceivable/sections/components/InvoicePreview.tsx
Outdated
Show resolved
Hide resolved
marcperezmonite
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements requested during design sync on 19.2, or in the slack channel.
Highest vat rate now chosen by default when selecting items.
Decrease number of clicks in create counterpart modal (remove buttons from first step).

In the same modal, added back button that returns to first step. I will add an arrow to it later.

There was a double border during focus state in quantity field. I removed the black border and kept only the blue-purple to keep consistent with the rest of the page. I also decreased the size of the quantity column and removed the gray border as requested by designers.




Small screen:
Hover before:
Hover after:
Different text alignment for the last columns to better distribute the values while we don't have amount and discount columns.


Fixed misalignments and grid in reminders' section. Large screen:


Small screen:
Additionally I fix the padding in currency selection of items dialogue. The padding was set on 0 to the left on purpose, so I presume this is required somewhere else. The "somewhere else" probably needs a more specific rule. Let me know if I could assist on that.


before:
after: