Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging dev #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Logging dev #16

wants to merge 6 commits into from

Conversation

BBScholar
Copy link
Contributor

Needs to be able to write to a flashdrive. Logs and formats well

@BBScholar BBScholar self-assigned this Nov 15, 2018
@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #16 into master will increase coverage by 1.78%.
The diff coverage is 30.43%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #16      +/-   ##
===========================================
+ Coverage      2.04%   3.83%   +1.78%     
- Complexity        4       6       +2     
===========================================
  Files            12      13       +1     
  Lines           342     365      +23     
  Branches          4       8       +4     
===========================================
+ Hits              7      14       +7     
- Misses          335     349      +14     
- Partials          0       2       +2
Impacted Files Coverage Δ Complexity Δ
...rc/main/kotlin/frc/team5499/frc2018Kotlin/Robot.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/frc/team5499/frc2018Kotlin/utils/CustomLogger.kt 31.81% <31.81%> (ø) 2 <2> (?)
...rc/team5499/frc2018Kotlin/subsystems/Drivetrain.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42c9e88...3c05c1d. Read the comment docs.

@connorworley
Copy link
Contributor

Please add some unit tests.


import java.io.File

object CustomLogger {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I prefer just "Logger"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants