[ADD/#8] 바텀 네비게이션 추가 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
leeeyubin
approved these changes
Jul 5, 2024
Comment on lines
17
to
18
| contentDescription = R.string.bottom_nav_home, | ||
| route = com.terning.feature.home.navigation.Home |
There was a problem hiding this comment.
이거 import 할 때 import com.terning.feature.home.navigation.Home 으로 해두면
route = Home으로만 작성해줄 수 있어요!!
Comment on lines
1
to
2
| package com.terning.feature.myPage | ||
|
|
There was a problem hiding this comment.
패키징 관련해서도 컨벤션 맞추는 게 좋을 것 같은데 소문자로 가는 거 어때용,,?
보통은 mypage로 작성해주는 것 같아요!!
Hyobeen-Park
approved these changes
Jul 5, 2024
Comment on lines
1
to
2
| package com.terning.feature.myPage | ||
|
|
묘하게 연두색이 아니라 진짜 대놓고 연두색이네요 ㅜㅜ 감사해용 바로 바꿨씁니다!!! |
boiledEgg-s
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
8.mp4
📢 To Reviewers