[UI/#55] 캘린더뷰 / 다이얼로그 구현 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alog # Conflicts: # feature/src/main/java/com/terning/feature/intern/component/ScrapCancelDialog.kt
Hyobeen-Park
approved these changes
Jul 18, 2024
| text = R.string.dialog_scrap_cancel_button, | ||
| onButtonClick = /*{ | ||
| viewModel.updateScrapped(!state.isScrapped) | ||
| viewModel.updateScrapDialogVisible(false) |
leeeyubin
approved these changes
Jul 18, 2024
Comment on lines
109
to
114
| text = R.string.dialog_scrap_cancel_button, | ||
| onButtonClick = /*{ | ||
| viewModel.updateScrapped(!state.isScrapped) | ||
| viewModel.updateScrapDialogVisible(false) | ||
| }*/onClickScrapCancel, | ||
| modifier = Modifier.padding(bottom = 8.dp) |
Comment on lines
61
to
64
| .border( | ||
| width = 0.dp, | ||
| color = Grey200, | ||
| shape = RoundedCornerShape(bottomStart = 20.dp, bottomEnd = 20.dp) |
There was a problem hiding this comment.
width = 0.dp면 이 코드 안 써줘도 반영이 되지 않을까요,,,,? (저도 확실하지 않음,,ㅎ)
arinming
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
default.mp4
📢 To Reviewers
구현 예정 목록
안내 사항
Timber는 현재 다이얼로그에서 값이 제대로 반환되는지 확인하기 위함입니다!