[FEAT/#5] 온보딩 뷰 / 카카오 연결 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arinming
approved these changes
Jul 6, 2024
| .size(500.dp), | ||
| ) | ||
| KakaoButton( | ||
| title = stringResource(id = R.string.sign_in_kakao_button), |
There was a problem hiding this comment.
[where]_[what] 네이밍 컨벤션 다시 한 번 확인합니당!
| Row( | ||
| modifier = modifier | ||
| .fillMaxWidth() | ||
| .background(Color.Yellow) |
There was a problem hiding this comment.
요거는 안드 디자인 시스템 Yellow 임의로 사용하신 건가용?
There was a problem hiding this comment.
네! 임의로 사용했습니당 추후에 로그인 뷰 UI 구현할 때 수정할게요!!!
boiledEgg-s
approved these changes
Jul 6, 2024
Hyobeen-Park
approved these changes
Jul 6, 2024
| @@ -1,9 +1,12 @@ | |||
| package com.terning.point | |||
|
|
|||
| import android.app.Application | |||
| import android.util.Log | |||
There was a problem hiding this comment.
요거 지금 쓰고 있는거 아니면 빼도 될 것 같아요!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240706_174931_Terning-Android.mp4
📢 To Reviewers
디코 안드 채널에 올려둔 걸로 로컬프로퍼티 수정해주세요!!! (확인했으면 디코에 체크표시 부탁함요!)