[FEAT/#99] 공고 뷰 / 스크랩 연동 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-api # Conflicts: # app/src/main/java/com/terning/point/di/DataSourceModule.kt # app/src/main/java/com/terning/point/di/RepositoryModule.kt # app/src/main/java/com/terning/point/di/ServiceModule.kt
…-api # Conflicts: # app/src/main/java/com/terning/point/di/RepositoryModule.kt # app/src/main/java/com/terning/point/di/ServiceModule.kt # data/src/main/java/com/terning/data/dto/response/SearchViewsResponseDto.kt
…-api # Conflicts: # app/src/main/java/com/terning/point/di/AuthInterceptor.kt # app/src/main/java/com/terning/point/di/DataSourceModule.kt # app/src/main/java/com/terning/point/di/RepositoryModule.kt # app/src/main/java/com/terning/point/di/ServiceModule.kt # feature/src/main/java/com/terning/feature/main/MainNavigator.kt
…-api # Conflicts: # app/src/main/java/com/terning/point/di/AuthInterceptor.kt # app/src/main/java/com/terning/point/di/DataSourceModule.kt # app/src/main/java/com/terning/point/di/RepositoryModule.kt # app/src/main/java/com/terning/point/di/ServiceModule.kt # data/src/main/java/com/terning/data/service/InternService.kt # feature/src/main/java/com/terning/feature/intern/InternRoute.kt # feature/src/main/java/com/terning/feature/intern/InternViewModel.kt # feature/src/main/java/com/terning/feature/main/MainNavigator.kt # feature/src/main/java/com/terning/feature/search/search/component/SearchIntern.kt
…-api # Conflicts: # app/src/main/java/com/terning/point/di/DataSourceModule.kt # app/src/main/java/com/terning/point/di/RepositoryModule.kt # app/src/main/java/com/terning/point/di/ServiceModule.kt
…-api # Conflicts: # data/src/main/java/com/terning/data/repositoryimpl/SearchRepositoryImpl.kt # domain/src/main/java/com/terning/domain/repository/SearchRepository.kt # feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt # feature/src/main/java/com/terning/feature/search/search/component/SearchInternList.kt # feature/src/main/java/com/terning/feature/search/search/model/SearchScrapsListState.kt # feature/src/main/java/com/terning/feature/search/search/model/SearchViewsListState.kt
Closed
2 tasks
leeeyubin
approved these changes
Jul 18, 2024
Comment on lines
49
to
+50
| modifier = Modifier | ||
| .size(width = 300.dp, height = 412.dp) | ||
| .size(width = 300.dp, height = 472.dp) |
Comment on lines
72
to
+73
| internshipAnnouncementId = 1, | ||
| title = "sadsa", | ||
| title = "안녕안녕안녕안녕안녕안녕안녕안녕안녕안녕안녕안녕안녕안녕안녕안녕안녕안녕안녕안녕", |
There was a problem hiding this comment.
3줄 뷰 확인용으로,.,.흑흡 석준오빠가 구현하면서 없애줄거예용ㅇ
Comment on lines
+61
to
+64
| ).onSuccess { | ||
| _scrapState.update { | ||
| it.copy(isScrap = UiState.Success(true)) | ||
| } |
There was a problem hiding this comment.
it을 response처럼 명시해주면 더 좋을 것 같아요!
Comment on lines
+234
to
+250
| onButtonClick = { | ||
| if (state.isPaletteOpen) { | ||
| viewModel.updatePaletteOpen(false) | ||
| viewModel.postScrap(announcementId, selectedColorIndex) | ||
| viewModel.updateColorChange(false) | ||
| viewModel.updateScrapDialogVisible(false) | ||
| } else { | ||
| if (state.isColorChange) { | ||
| viewModel.postScrap(announcementId, selectedColorIndex) | ||
| viewModel.updateColorChange(false) | ||
| } else { | ||
| viewModel.postScrap(announcementId, 0) | ||
| } | ||
| viewModel.updateScrapDialogVisible(false) | ||
| } | ||
| }, | ||
| modifier = Modifier.padding(bottom = 8.dp) |
There was a problem hiding this comment.
if~else문이 많이 반복되는 것 같은데 시간 되면 함수로 빼줘도 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
99.mp4
📢 To Reviewers