[FEAT/#113] 필터링 재설정 서버통신 구현 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
Jul 18, 2024
Comment on lines
17
to
24
| ) { | ||
| fun toHomeFilteringInfoModel(): HomeFilteringInfoModel = | ||
| HomeFilteringInfoModel( | ||
| grade = this.grade, | ||
| workingPeriod = this.workingPeriod, | ||
| startYear = startYear, | ||
| startMonth = startMonth, | ||
| ) |
There was a problem hiding this comment.
startYear랑 startMonth는 this를 빼준 의도가 있나용?
Comment on lines
184
to
185
| isEnabled = currentGrade in 0..3 && currentWorkingPeriod in 0..2 | ||
| ) |
Comment on lines
7
to
+9
| val showSearchResults: Boolean = false, | ||
| val existSearchResults: Boolean = false, | ||
| val searchResults: List<InternData> = emptyList(), | ||
| // val searchResults: List<InternData> = emptyList(), |
There was a problem hiding this comment.
앗 이거는 제 코드가 아니었어가지고,,, 머지 다 되면 없어질 것 같아요..!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240718_201516_Terning-Android.mp4
📢 To Reviewers