Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX/#150] 스크랩 1차 QA 해결 #156

Merged
merged 6 commits into from
Jul 19, 2024
Merged

[FIX/#150] 스크랩 1차 QA 해결 #156

merged 6 commits into from
Jul 19, 2024

Conversation

arinming
Copy link
Contributor

⛳️ Work Description

  • QA 2개뺴고 해결

📸 Screenshot

📢 To Reviewers

  • 일단 올립니다.

@arinming arinming added FIX 🔨 버그 및 오류 해결 아린💛 아린 labels Jul 19, 2024
@arinming arinming self-assigned this Jul 19, 2024
@arinming arinming linked an issue Jul 19, 2024 that may be closed by this pull request
[FIX] 스크랩 1차 QA 해결 #150
Closed
10 tasks
leeeyubin
leeeyubin approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~

boiledEgg-s
boiledEgg-s approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 써먹을게요!! 너무 잘하셨습니다~~

Hyobeen-Park
Hyobeen-Park approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿~!!!

core/src/main/java/com/terning/core/designsystem/theme/Color.kt
@@ -14,7 +14,7 @@ val Grey500 = Color(0xFF373737)
val Black = Color(0xFF171717)

// Main Color
val TerningMain = Color(0xFF1EA65E)
val TerningMain = Color(0xFF1EAC61)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고!!

@arinming arinming merged commit df8a5b0 into develop Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeeyubin leeeyubin leeeyubin approved these changes

@boiledEgg-s boiledEgg-s boiledEgg-s approved these changes

@Hyobeen-Park Hyobeen-Park Hyobeen-Park approved these changes

Assignees

@arinming arinming

Labels
FIX 🔨 버그 및 오류 해결 아린💛 아린
Projects
Terning-Android
Status: Done
Milestone
1차 스프린트 마무리 작업
Development

Successfully merging this pull request may close these issues.

[FIX] 스크랩 1차 QA 해결
4 participants
@arinming @Hyobeen-Park @boiledEgg-s @leeeyubin