Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX/#154] 홈 뷰 1차 QA #157

Merged
merged 7 commits into from
Jul 19, 2024
Merged

[FIX/#154] 홈 뷰 1차 QA #157

merged 7 commits into from
Jul 19, 2024

Conversation

Hyobeen-Park
Copy link
Member

⛳️ Work Description

  • 색상 수정 다이얼로그
  • 화면 전환 방식 변경

📸 Screenshot

📢 To Reviewers

@Hyobeen-Park Hyobeen-Park added FIX 🔨 버그 및 오류 해결 효빈💚 효빈 labels Jul 19, 2024
@Hyobeen-Park Hyobeen-Park self-assigned this Jul 19, 2024
Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 잘하셨습니다~!! 남은 QA도 화이팅

Comment on lines 237 to +242
if (state.isPaletteOpen) {
viewModel.updatePaletteOpen(false)
viewModel.updateColorChange(false)
viewModel.updateScrapDialogVisible(false)
viewModel.patchScrap(
scrapId = homeTodayInternModel.scrapId,
colorIndex = selectedColorIndex,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 코드를 보니까 생각난건데 LaunchedEffect(state.isPaletteOpen)과 같은 형식으로 통신을 관리하는 방법도 좋을 것 같네요! 물론 저도 그렇게 관리하진 않았어요ㅎ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 좋은 생각이네요!!

Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고다.

Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿~

@Hyobeen-Park Hyobeen-Park merged commit c03631f into develop Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIX 🔨 버그 및 오류 해결 효빈💚 효빈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 홈 뷰 1차 QA
4 participants