Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX/#151] 캘린더 1차 QA 해결 #158

Merged
merged 14 commits into from
Jul 19, 2024
Merged

[FIX/#151] 캘린더 1차 QA 해결 #158

merged 14 commits into from
Jul 19, 2024

Conversation

boiledeggg
Copy link
Member

@boiledeggg boiledeggg commented Jul 19, 2024 •
edited
Loading

⛳️ Work Description

  • 뷰 전환 시 달력 매핑 깨짐
  • 달력 터치 영역 증가
  • 공고 정보 다이얼로그의 이미지에 라운딩 처리 (주간 캘린더에서 접근 시 deadline = selectedDate가 추가되어야 함)
  • 공고 정보 다이얼로그 내부 패딩 수정 (하드코딩 dp 추가)
  • 공고 정보 다이얼로그 외부 영역 터치 이벤트 변경
  • 공고 정보 다이얼로그 내부 컨텐츠 크기 변경
  • 달력 폰트 수정

📸 Screenshot

📢 To Reviewers

  • 1차 QA 해결했습니다!!

@boiledeggg boiledeggg added FIX 🔨 버그 및 오류 해결 석준💜 석준 labels Jul 19, 2024
@boiledeggg boiledeggg self-assigned this Jul 19, 2024
arinming
arinming approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완벽하다.

leeeyubin
leeeyubin approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어요~

Hyobeen-Park
Hyobeen-Park approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어용👏🏻👏🏻👏🏻

@boiledeggg
Merge remote-tracking branch 'origin/develop' into fix/#151-calendar
43ca45a 
# Conflicts:
#	feature/src/main/java/com/terning/feature/home/home/component/HomeTodayInternDialog.kt
@boiledeggg
[FIX/#151] develop 컨플릭 해결
721f81a
@boiledeggg boiledeggg merged commit 3d821a1 into develop Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinming arinming arinming approved these changes

@Hyobeen-Park Hyobeen-Park Hyobeen-Park approved these changes

@leeeyubin leeeyubin leeeyubin approved these changes

Assignees

@boiledeggg boiledeggg

Labels
FIX 🔨 버그 및 오류 해결 석준💜 석준
Projects
None yet
Milestone
1차 스프린트 마무리 작업
Development

Successfully merging this pull request may close these issues.

[FIX] 캘린더 1차 QA 해결
4 participants
@boiledeggg @arinming @Hyobeen-Park @leeeyubin