-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR/#181] 월간 캘린더 리팩토링 #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호... 정말 한 패키지에 너무 많은 파일이 들어갈 것 같긴 하네요..!! feature별로 나누는 것도 괜찮을 것 같아요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맵퍼 있어서 그런지 확실히 가독성 편안하네요 ㅠ ㅠ feature로 나누는거 찬성입니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다! 저도 괜찮은 방법인 것 같아요:)
⛳️ Work Description
📸 Screenshot
UI 수정 없습니다!
📢 To Reviewers
엔티티랑 매퍼 클래스를 추가하긴 했는데, 패키지 하나에 넣으니까 좀 지저분해질 것 같다는 느낌이 다시 드네요,,
response/request 식으로 나누진 않더라도 feature별로 나눠보는 건 어떨까요?!