Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR/#181] 월간 캘린더 리팩토링 #182

Merged
merged 12 commits into from
Aug 18, 2024

Conversation

boiledEgg-s
Copy link
Member

@boiledEgg-s boiledEgg-s commented Aug 16, 2024

⛳️ Work Description

  • 엔티티 경로 수정
  • 캘린터 관련 dto 매퍼 클래스 구현
  • 월간 캘린더 컴포저블 상태 호이스팅
  • 컴포저블 메서드 접근자 지정

📸 Screenshot

UI 수정 없습니다!

📢 To Reviewers

엔티티랑 매퍼 클래스를 추가하긴 했는데, 패키지 하나에 넣으니까 좀 지저분해질 것 같다는 느낌이 다시 드네요,,
response/request 식으로 나누진 않더라도 feature별로 나눠보는 건 어떨까요?!

Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호... 정말 한 패키지에 너무 많은 파일이 들어갈 것 같긴 하네요..!! feature별로 나누는 것도 괜찮을 것 같아요!!

Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맵퍼 있어서 그런지 확실히 가독성 편안하네요 ㅠ ㅠ feature로 나누는거 찬성입니당

Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 저도 괜찮은 방법인 것 같아요:)

@boiledEgg-s boiledEgg-s merged commit 499a5e3 into develop Aug 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REFACTOR ♻️ 전면 수정 석준💜 석준
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 월간 캘린더 리팩토링
4 participants