[REFACTOR/#188] 컴포넌트 문서화 및 추가 리팩토링 #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boiledEgg-s
approved these changes
Aug 20, 2024
| @@ -44,7 +44,7 @@ import kotlinx.coroutines.delay | |||
| @Composable | |||
| fun StartHomeScreen( | |||
| modifier: Modifier = Modifier, | |||
| navController: NavController = rememberNavController() | |||
| navigateToHome: () -> Unit | |||
There was a problem hiding this comment.
모든 화면을 이렇게 관리하는게 일관돼 보여 좋네요!
최근에 알게 된건데 람다를 사용하는게 꼭 리컴포지션을 줄이는 방법은 아니라고 하더라고요..
람다도 리컴포지션의 대상이 될 수 있다네요.. 그래서 remember로 관리해주는게 좋다고 하더라구요
나중에 함 읽어봐요~ 당장 적용할 순 없겠지만 알고 있으면 도움은 되겠죠? (저는 읽어보지 않았지만)
https://velog.io/@skydoves/compose-stability
arinming
approved these changes
Aug 21, 2024
Comment on lines
+12
to
19
| /** | ||
| * contentDescription을 사용하지 않고 Image를 편리하게 사용할 수 있는 함수입니다. | ||
| * | ||
| * @param painter 이미지 리소스 ID입니다. | ||
| * @param modifier Image의 Modifier입니다. | ||
| */ | ||
| @Composable | ||
| fun TerningImage( |
There was a problem hiding this comment.
contentDescription� 없이 작성하기 좋겠당..!
Hyobeen-Park
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
TerningImage사용📢 To Reviewers