Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor#186] 탐색 기본 뷰 / 리팩토링 #190

Closed
wants to merge 8 commits into from
Closed

[Refactor#186] 탐색 기본 뷰 / 리팩토링 #190

wants to merge 8 commits into from

Conversation

arinming
Copy link
Contributor

⛳️ Work Description

  • �스크랩 많은 공고, 조회수 많은 공고 모델 명 수정
  • 스크랩 많은 공고, 조회수 많은 공고 맵퍼 생성
  • 검색창 컴포저블 문서화

📸 Screenshot

뷰 수정 없습니다.

📢 To Reviewers

  • 조회수, 뷰 많은 공고 각각 서버에서 데이터가 빈 값이 와서 확인 요청한 상태입니당

@arinming arinming added REFACTOR ♻️ 전면 수정 아린💛 아린 labels Aug 21, 2024
@arinming arinming added this to the 2차 스프린트 작업 milestone Aug 21, 2024
@arinming arinming self-assigned this Aug 21, 2024
boiledEgg-s
boiledEgg-s approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습다닷~👏

data/src/main/java/com/terning/data/dto/response/SearchResultResponseDto.kt Outdated
@@ -35,9 +35,9 @@ data class SearchResultResponseDto(
val deadline: String,
)

fun toSearchResultEntity(): List<SearchResultModel> {
fun toSearchResultEntity(): List<SearchResult> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 매퍼 파일 만들어주세요!

Copy link
Contributor Author

@arinming arinming Aug 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉쓰!!~! 이게 검색 뷰 여서 아직 수정하지 않았던 건데 SearchResult는 왜 수정했을까요,,,,,,? ㅜㅜ 여기서 한 번에 하겠습니다

feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NavHostController는 SearchRoute까지 호이스팅하거나 유빈이 코드처럼 아예 Navigation 파일로 호이스팅하는게 좋을 것 같아요!!

Copy link
Contributor Author

@arinming arinming Aug 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네엡 감사합니당~!!! 바로 수정해볼게욤

feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt Outdated
searchViewsList: List<InternshipAnnouncementModel>,
searchScrapsList: List<InternshipAnnouncementModel>,
searchViewsList: List<SearchAnnouncement>,
searchScrapsList: List<SearchAnnouncement>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 List를 선언하여 컴포저블에 넘겨도 안바뀌는 변수로 취급하지 않아 리컴포지션의 대상이 된다고 하더라고요,,
그래서 Immutable 컬렉션 혹은 Persistent 컬렉션 사용을 권장한다고 합니다! 단순히 .toImmutableList(), ImmutableList<>를 사용하면 된답니다~!!

근데 만약 실시간으로 아이템이 추가돼야 하는 리스트의 경우에 Immutable을 사용해도 되는지는 몰루겠네요ㅎㅎ
저도 메이커스 면접에서 배운거라 그냥 공유만 하는겁니다!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉스 소중한 정보 공유 감사감사감사하비다 ㅡㅡ,,.! 해당 모델은 스크랩 많은 뷰 / 조회수 많은 뷰 공고 모델이라서, 뷰에 진입했을 때 기준으로 많이 띄우면 될 것 같고 실시간으로 아이템이 추가되는 건 아니라 Immutable 사용해보겠습ㄴ닷!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오!!! 좋은 정보 감사합니다...!!!!

Hyobeen-Park
Hyobeen-Park reviewed Aug 21, 2024
View reviewed changes
data/src/main/java/com/terning/data/dto/response/SearchResultResponseDto.kt Outdated
@@ -1,6 +1,6 @@
package com.terning.data.dto.response

import com.terning.domain.entity.response.SearchResultModel
import com.terning.domain.entity.search.SearchResult
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 지금 사용되는 내용이 아니라면 삭제해주면 좋을 것 같아요!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

섬세하시닷!~

feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt Outdated
searchViewsList: List<InternshipAnnouncementModel>,
searchScrapsList: List<InternshipAnnouncementModel>,
searchViewsList: List<SearchAnnouncement>,
searchScrapsList: List<SearchAnnouncement>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오!!! 좋은 정보 감사합니다...!!!!

leeeyubin
leeeyubin approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~!! 수고했어요!!!

@arinming arinming closed this Aug 22, 2024
@arinming arinming deleted the refactor#186-search branch August 22, 2024 15:13
@arinming arinming restored the refactor#186-search branch August 22, 2024 15:15
@arinming arinming deleted the refactor#186-search branch August 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeeyubin leeeyubin leeeyubin approved these changes

@boiledEgg-s boiledEgg-s boiledEgg-s approved these changes

@Hyobeen-Park Hyobeen-Park Hyobeen-Park approved these changes

Assignees

@arinming arinming

Labels
REFACTOR ♻️ 전면 수정 아린💛 아린
Projects
Terning-Android
Status: Done
Milestone
2차 스프린트 작업
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 탐색 기본 뷰 / 리팩토링
4 participants
@arinming @Hyobeen-Park @boiledEgg-s @leeeyubin