[UI/#202] 마이페이지 뷰 / UI 수정 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arinming
approved these changes
Aug 28, 2024
boiledEgg-s
approved these changes
Aug 28, 2024
| UserProfile( | ||
| name = name, | ||
| profile = profile, | ||
| onEditClick = { onEditClick() } |
There was a problem hiding this comment.
이렇게 람다 형식으로 함수를 넘기는 이유가 있을까요??
람다가 새로운 객체를 생성하는 개념이라, 굳이 필요가 없는 경우엔 사용하지 않는게 좋을 것 같아요~
Suggested change
| onEditClick = { onEditClick() } | |
| onEditClick = onEditClick |
There was a problem hiding this comment.
맞습니당!! 안 그래도 급하게 코드 짜느라 놓친 부분인 것 같네요ㅜㅜ 조언 감사합니당
한 번 더 수정하도록 할게요~!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240827_024123_Terning-Android.mp4
📢 To Reviewers