-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR/#212] 다이얼로그 / 리팩토링 #213
Merged
Merged
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
be7abcb
[MOD/#212] 스크랩 취소 다이얼로그 추출
boiledeggg 7a0fa35
[FEAT/#212] 스크랩 취소와 캘린더 연동
boiledeggg 5f95377
[UI/#212] 스크랩 취소 프리뷰
boiledeggg 337c03c
[MOD
boiledeggg 72279a2
[FEAT/#212] 공고 다이얼로그와 달력 연동
boiledeggg 610a9a1
[DEL/#212] 스크랩 관리 코드 제거
boiledeggg b483d56
[DEL/#212] 라이브러리 import 정리
boiledeggg 0a94565
[CHORE/#212] Resource 의존성 수정
boiledeggg 8bb8578
[ADD/#212] 스크랩 색상 추가
boiledeggg 4dfff2a
[ADD/#212] 컬러 타입 추가
boiledeggg 67dfbf9
[ADD/#212] 컬러 코드 추가
boiledeggg 37c8b2b
[FIX/#212] 컬러 타입 수정
boiledeggg a7ccfe7
[FEAT/#212] 컬러 팔레트 수정 및 연동
boiledeggg f856344
[FEAT/#212] 스크랩 다이얼로그 UI 및 기능 수정
boiledeggg cd13ab8
[DEL/#212] 라이브러리 정리
boiledeggg c424ad6
[FIX/#212] 버튼 관련 로직 수정
boiledeggg 40156b6
[UI/#212] 스크랩창 기타 UI 수정
boiledeggg dd3d488
[UI/#212] 취소창 기타 UI 수정
boiledeggg 6f91c70
[DEL/#212] 라이브러리 정리
boiledeggg 222a636
[FIX/#212] 스크랩수정 버튼 오류 해결
boiledeggg ddc1cc1
[DEL/#212] 로그 삭제
boiledeggg 536c53c
[DEL/#212] 라이브러리 삭제
boiledeggg 05ffbe0
[REFACTOR/#212] 리뷰 기반 코드 수정
boiledeggg 49b2275
[DOC/#212] RadioButtonGroups 문서화
boiledeggg 0eac245
[CHORE/#212] 리소스 주석 추가
boiledeggg 571e43e
[UI/#212] 토스트메시지 추가
boiledeggg 52e6c48
Merge remote-tracking branch 'origin/develop' into refactor/#212-dialog
boiledeggg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
core/src/main/java/com/terning/core/extension/TextStyle.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.terning.core.extension | ||
|
||
import androidx.compose.runtime.Composable | ||
import androidx.compose.ui.platform.LocalDensity | ||
import androidx.compose.ui.text.TextStyle | ||
import androidx.compose.ui.unit.Dp | ||
|
||
@Composable | ||
fun TextStyle.getFixHeightByMaxLine(maxLine: Int): Dp = with(LocalDensity.current) { | ||
lineHeight.toDp() * maxLine | ||
} | ||
Comment on lines
+8
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 확장성이 너무 좋으네요 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package com.terning.core.type | ||
|
||
import androidx.compose.ui.graphics.Color | ||
import com.terning.core.designsystem.theme.CalBlue2 | ||
import com.terning.core.designsystem.theme.CalBlueBc | ||
import com.terning.core.designsystem.theme.CalBlueLi | ||
import com.terning.core.designsystem.theme.CalGreen2 | ||
import com.terning.core.designsystem.theme.CalGreenBc | ||
import com.terning.core.designsystem.theme.CalGreenLi | ||
import com.terning.core.designsystem.theme.CalOrange2 | ||
import com.terning.core.designsystem.theme.CalOrangeBc | ||
import com.terning.core.designsystem.theme.CalOrangeLi | ||
import com.terning.core.designsystem.theme.CalPink | ||
import com.terning.core.designsystem.theme.CalPinkBc | ||
import com.terning.core.designsystem.theme.CalPinkLi | ||
import com.terning.core.designsystem.theme.CalPurple | ||
import com.terning.core.designsystem.theme.CalPurpleBc | ||
import com.terning.core.designsystem.theme.CalPurpleLi | ||
import com.terning.core.designsystem.theme.CalRed | ||
import com.terning.core.designsystem.theme.CalRedBc | ||
import com.terning.core.designsystem.theme.CalRedLi | ||
|
||
enum class ColorType( | ||
val main: Color, | ||
val border: Color, | ||
val sub: Color | ||
) { | ||
RED(main = CalRed, border = CalRedLi, sub = CalRedBc), | ||
ORANGE(main = CalOrange2, border = CalOrangeLi, sub = CalOrangeBc), | ||
GREEN(main = CalGreen2, border = CalGreenLi, sub = CalGreenBc), | ||
BLUE(main = CalBlue2, border = CalBlueLi, sub = CalBlueBc), | ||
PURPLE(main = CalPurple, border = CalPurpleLi, sub = CalPurpleBc), | ||
PINK(main = CalPink, border = CalPinkLi, sub = CalPinkBc); | ||
|
||
companion object { | ||
fun findColorType(mainColor: Color): ColorType? = entries.find { it.main == mainColor } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
34 changes: 0 additions & 34 deletions
34
...ure/src/main/java/com/terning/feature/calendar/calendar/component/CalendarCancelDialog.kt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요기 import 정리 부탁드려요!