-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI/#191] 공고 상세 뷰 / 2차 UI로 전면 수정 #215
Merged
Merged
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5b9a03c
[Refactor] InternState 변경
arinming 474399c
[Refactor] 공고 상세 Navigation 변경
arinming a5f3caa
[FEAT/#191] 공고 상세 기업 정보 컴포넌트 변경
arinming e37e92f
Merge remote-tracking branch 'origin/develop' into ui/#191-announcement
arinming 45d79fb
[FEAT/#191] 공고 상세 기업 정보 데이터 로드 로직 변경
arinming 8e04191
[FEAT/#191] 공고 상세 기업 정보 데이터 불러오기
arinming 8913d5e
[FEAT/#191] D-Day 컴포넌트 생성
arinming 883a1dc
[FEAT/#191] InternTitle 생성
arinming f8c1be2
[FEAT/#191] Grey 375 추가 및 조회수 반영
arinming 266f419
[FEAT/#191] 인턴 상세 페이지 소제목 컴포넌트 변경
arinming e518f48
[FEAT/#191] 인턴 공고 요약 컴포넌트 변경
arinming a2a58ce
[FEAT/#191] 인턴 자격 요건 컴포넌트 변경
arinming 070a4ae
[FEAT/#191] 인턴 상세 정보 컴포넌트 변경
arinming 2739af5
[FEAT/#191] 인턴 상세 정보 컴포넌트 선택 영역 추가
arinming 71af2c5
[FEAT/#191] 인턴 상세 페이지 뒤로 가기 구현
arinming 32cf97d
[FEAT/#191] 코드 리뷰 기반 2차 수정
arinming 1892ea7
[FEAT/#191] 이미지 ContentScale 변경
arinming File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
301 changes: 72 additions & 229 deletions
301
feature/src/main/java/com/terning/feature/intern/InternRoute.kt
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 14 additions & 10 deletions
24
feature/src/main/java/com/terning/feature/intern/component/InternPageTitle.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 불필요한 것 같네요!!
그리고 왜 여기에 인자로 받은 modifier를 사용하신건가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
삭제했습니당!!!1감사해요