-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI/#218] 온보딩 / UI 수정 #219
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3a9f663
[UI/#216] 필터링 시작 화면 수정
leeeyubin b65f773
[UI/#216] 홈 시작 화면 수정
leeeyubin 34542d3
[UI/#216] 필터링 버튼 UI 수정
leeeyubin 6211928
[UI/#216] 필터링 버튼 UI 수정
leeeyubin df37526
[UI/#218] YearMonthPicker 구현
leeeyubin 90f1c9e
[MOVE/#218] 파일 위치 이동
leeeyubin 8b65715
[DEL/#218] 안 쓰는 라이브러리 삭제
leeeyubin 9b9c7d2
[FEAT/#218] 데이트피커 수정
leeeyubin 0a643bf
[FEAT/#218] 캘린더 확장함수 구현
leeeyubin a3c673a
[FEAT/#218] 캘린더 확장함수 구현
leeeyubin de56489
[FEAT/#218] 로직 수정
leeeyubin aa2531f
[FEAT/#218] 로직 수정
leeeyubin b7d263c
[FEAT/#218] 캘린더 오류 수정
leeeyubin 990a776
[FEAT/#218] 필터링 버튼 로직 수정
leeeyubin 93ca5c6
[FEAT/#218] 필터링 원 로직 수정
leeeyubin 016fc7c
[FEAT/#218] 필터링 투 로직 수정
leeeyubin 48ee63a
[FEAT/#218] resolving conflict
leeeyubin e410bb5
[FEAT/#218] 패딩값 수정
leeeyubin 278d274
[FEAT/#218] 함수 합치기
leeeyubin fc8c1f3
[FEAT/#218] 코드 리뷰 반영
leeeyubin f5d1c60
Merge branch 'develop' of https://github.com/teamterning/Terning-Andr…
leeeyubin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package com.terning.core.extension | ||
|
||
import java.util.Calendar | ||
|
||
val Calendar.currentYear: Int get() = get(Calendar.YEAR) | ||
|
||
val Calendar.currentMonth: Int get() = get(Calendar.MONTH) + 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package com.terning.core.util | ||
|
||
object CalendarDefaults { | ||
const val START_YEAR = 2010 | ||
const val END_YEAR = 2030 | ||
const val START_MONTH = 1 | ||
const val END_MONTH = 12 | ||
} |
8 changes: 0 additions & 8 deletions
8
feature/src/main/java/com/terning/feature/filtering/filtering/FilteringSideEffect.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
feature/src/main/java/com/terning/feature/filtering/filteringone/FilteringOneSideEffect.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
package com.terning.feature.filtering.filteringone | ||
|
||
sealed class FilteringOneSideEffect { | ||
data object NavigateUp : FilteringOneSideEffect() | ||
} |
6 changes: 6 additions & 0 deletions
6
feature/src/main/java/com/terning/feature/filtering/filteringone/FilteringOneState.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
package com.terning.feature.filtering.filteringone | ||
|
||
data class FilteringOneState( | ||
val isButtonValid: Boolean = false, | ||
val grade: Int = -1 | ||
) |
30 changes: 30 additions & 0 deletions
30
feature/src/main/java/com/terning/feature/filtering/filteringone/FilteringOneViewModel.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
package com.terning.feature.filtering.filteringone | ||
|
||
import androidx.lifecycle.ViewModel | ||
import androidx.lifecycle.viewModelScope | ||
import kotlinx.coroutines.flow.MutableSharedFlow | ||
import kotlinx.coroutines.flow.MutableStateFlow | ||
import kotlinx.coroutines.flow.SharedFlow | ||
import kotlinx.coroutines.flow.StateFlow | ||
import kotlinx.coroutines.flow.asSharedFlow | ||
import kotlinx.coroutines.flow.asStateFlow | ||
import kotlinx.coroutines.launch | ||
|
||
class FilteringOneViewModel : ViewModel() { | ||
|
||
private val _state: MutableStateFlow<FilteringOneState> = MutableStateFlow(FilteringOneState()) | ||
val state: StateFlow<FilteringOneState> get() = _state.asStateFlow() | ||
|
||
private val _sideEffects = MutableSharedFlow<FilteringOneSideEffect>() | ||
val sideEffects: SharedFlow<FilteringOneSideEffect> get() = _sideEffects.asSharedFlow() | ||
|
||
fun updateGradeAndButton(grade: Int) { | ||
_state.value = _state.value.copy( | ||
grade = grade, | ||
isButtonValid = true | ||
) | ||
} | ||
|
||
fun navigateUp() = | ||
viewModelScope.launch { _sideEffects.emit(FilteringOneSideEffect.NavigateUp) } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
편-안