[ADD/#19] TerningTextField #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
leeeyubin
approved these changes
Jul 8, 2024
Comment on lines
34
to
51
| fun TerningTextField( | ||
| value: String, | ||
| onValueChange: (String) -> Unit, | ||
| textStyle: TextStyle, | ||
| textColor: Color = TerningMain, | ||
| cursorBrush: Brush = SolidColor(TerningMain), | ||
| hint: String = "", | ||
| hintColor: Color = TerningMain, | ||
| strokeWidth: Float = 1f, | ||
| drawLineColor: Color, | ||
| leftIcon: Int? = null, | ||
| leftIconColor: Color = TerningMain, | ||
| maxTextLength: Int? = null, | ||
| showTextLength: Boolean = false, | ||
| helperMessage: String = "", | ||
| helperIcon: Int? = null, | ||
| helperColor: Color = TerningMain, | ||
| ) { |
There was a problem hiding this comment.
파라미터 순서 맞춰주면 좋을 것 같아요!
보통은 기본 값이 없는 파라미터(필수 값)를 두고 그 뒤에 옵셔널 값을 둬요!
Modifier는 옵서녈의 위에 두면 됩니다!!
There was a problem hiding this comment.
오 새롭게 알아갑니다!!!!!!!!!!
Comment on lines
22
to
26
| @Composable get() = navController | ||
| .currentBackStackEntryAsState().value?.destination | ||
|
|
||
| val startDestination = SignIn | ||
| val startDestination = Search | ||
|
|
Comment on lines
32
to
37
|
|
||
| @Composable | ||
| fun TerningTextField( | ||
| value: String, | ||
| onValueChange: (String) -> Unit, | ||
| textStyle: TextStyle, |
There was a problem hiding this comment.
이 함수가 텍스트필드 중에서도 기본인 거니까 TerningBasicTextField로 명시해주는 것도 괜찮은 방법일 것 같네용
Comment on lines
24
to
26
| onValueChange = onValueChange, | ||
| textStyle = TerningTypography().detail1, | ||
| textColor = Black, |
There was a problem hiding this comment.
스타일 적용할 때 TerningTypography().detail1로 바로 적용하면 새로운 인스턴스를 생성하는 거라 TerningTheme.typography.detail1로 해줘야 할 것 같아요!
| value: String, | ||
| onValueChange: (String) -> Unit, | ||
| textStyle: TextStyle, | ||
| textColor: Color = TerningMain, |
There was a problem hiding this comment.
확인해보니 SearchTextField랑 NameTextField 모두 각각의 textColor를 넣어주고 있는 것 같은데 여기서 디폴트로 TerningMain 색을 넣어준 이유는 무엇인가용?
Suggested change
| textColor: Color = TerningMain, | |
| textColor: Color, |
이렇게 기본 값 없이도 갈 수 있을 것 같아요!
Comment on lines
109
to
114
| if (showTextLength && maxTextLength != null) { | ||
| Text( | ||
| text = "${value.length}/$maxTextLength", | ||
| style = TerningTypography().button3, | ||
| color = Grey300, | ||
| ) |
boiledEgg-s
approved these changes
Jul 9, 2024
Hyobeen-Park
approved these changes
Jul 9, 2024
Comment on lines
+59
to
+63
| keyboardOptions = KeyboardOptions(imeAction = ImeAction.Done), | ||
| keyboardActions = KeyboardActions(onDone = { | ||
| keyboardController?.hide() | ||
| focusManager.clearFocus() | ||
| }), |
There was a problem hiding this comment.
이부분이 키보드 숨기는 부분인거 맞죠?!?? 진짜 최고다👍🏻👍🏻
| Box(modifier = Modifier.weight(1f)) { | ||
| if (value.isEmpty()) { | ||
| Text( | ||
| text = hint, style = textStyle, color = hintColor |
| } | ||
| if (showTextLength && maxTextLength != null) { | ||
| Text( | ||
| text = "${value.length}/$maxTextLength", |
# Conflicts: # feature/src/main/res/values/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
📢 To Reviewers