[UI/#214] 달력 / 2차 스프린트 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # feature/src/main/java/com/terning/feature/calendar/calendar/component/CalendarDetailDialog.kt # feature/src/main/java/com/terning/feature/calendar/list/CalendarListScreen.kt # feature/src/main/java/com/terning/feature/calendar/list/CalendarListViewModel.kt # feature/src/main/java/com/terning/feature/calendar/week/CalendarWeekScreen.kt # feature/src/main/java/com/terning/feature/calendar/week/CalendarWeekViewModel.kt
leeeyubin
approved these changes
Sep 8, 2024
Comment on lines
25
to
+27
| fun NavGraphBuilder.calendarNavGraph( | ||
| navHostController: NavController | ||
| navHostController: NavController, | ||
| paddingValues: PaddingValues |
Hyobeen-Park
approved these changes
Sep 8, 2024
arinming
approved these changes
Sep 9, 2024
| @@ -37,7 +41,7 @@ fun NavGraphBuilder.calendarNavGraph( | |||
| } | |||
| ) { | |||
| CalendarRoute( | |||
| navigateUp = navHostController::navigateUp, | |||
| modifier = Modifier.padding(paddingValues), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
빈화면 UI
슬라이드 모션
KakaoTalk_Video_2024-09-07-15-32-51.mp4
📢 To Reviewers
계획은 이 브랜치에서 자식 브랜치를 하나 파서 작업하고 순차적으로 머지할 예정입니다.
해당 계획과는 별개로 이 PR엔 리뷰를 달아주시면 됩니다~!!