[UI/#223] 온보딩 그래픽 추가 #224
Merged
[UI/#223] 온보딩 그래픽 추가 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyobeen-Park
approved these changes
Sep 8, 2024
| import com.airbnb.lottie.compose.LottieAnimation | ||
| import com.airbnb.lottie.compose.LottieCompositionSpec | ||
| import com.airbnb.lottie.compose.LottieConstants |
There was a problem hiding this comment.
이 임포트 사용하지 않는 것 같은데 확인 부탁드려요!!
Comment on lines
+93
to
+94
| .height(372.dp) | ||
| .padding(horizontal = 24.dp) |
There was a problem hiding this comment.
height 고정dp를 없애고 아래에도 padding을 고정으로 넣는건 어떨까요??
There was a problem hiding this comment.
기본 이미지가 작나용..? fillMaxHeight를 했을 때는 어떨지 궁금하네욤
There was a problem hiding this comment.
밑에 패딩을 넣어도 dp 값이 커서 비슷한 문제가 있을 것 같아요;;
기본 이미지의 높이가 너무 커서 그냥 넣는 건 불가능하고,
프레임의 크기를 고정시키고 그 안에 이미지를 넣을 때 위아래 넘어가는 부분을 잘라내는 식으로 구현된 상태입니다!!
가로의 크기는 화면 크기에 맞추고 높이를 372dp로 설정한 상태에서,
로티 이미지를 넣을 때 가운데를 기준으로 372dp를 넘어가는 부분이 잘리게 되는 겁니다.
leeeyubin
approved these changes
Sep 8, 2024
Comment on lines
+93
to
+94
| .height(372.dp) | ||
| .padding(horizontal = 24.dp) |
There was a problem hiding this comment.
기본 이미지가 작나용..? fillMaxHeight를 했을 때는 어떨지 궁금하네욤
arinming
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
KakaoTalk_Video_2024-09-07-16-19-00.mp4
📢 To Reviewers