[FEAT/#221] 마이페이지 뷰 / 서버통신 구현 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into feat/#221-my-page
boiledEgg-s
approved these changes
Sep 8, 2024
| @@ -63,14 +65,24 @@ fun MyPageRoute( | |||
| ) | |||
| } | |||
|
|
|||
| DisposableEffect(lifecycleOwner) { | |||
There was a problem hiding this comment.
이거 첨 보네요!
컴포저블이 사라질 때 발생하는건가요??
There was a problem hiding this comment.
네! 맞습니당 화면이 꺼질 때 원래 상태바 색깔로 바꾸기 위해 넣어주었습니다!
| onOpinionClick: () -> Unit, | ||
| onServiceClick: () -> Unit, | ||
| onPersonalClick: () -> Unit, | ||
| onEditClick: () -> Unit = {}, |
There was a problem hiding this comment.
서버 통신 실패 시 화면을 그리고자 했는데, Screen에 기본값으로 넣어두지 않으면 성공 시 화면에 사용하는 모든 것들을 다 연결을 해줘야 해서 선택적으로 사용하고자 기본값을 다 추가하였습니다!
Hyobeen-Park
approved these changes
Sep 8, 2024
| DEFAULT(drawableResId = R.drawable.ic_terning_profile_default, stringValue = "default"); | ||
|
|
||
| companion object { | ||
| fun fromString(value: String): ProfileImage = when (value) { |
| @@ -63,14 +65,24 @@ fun MyPageRoute( | |||
| ) | |||
| } | |||
|
|
|||
| DisposableEffect(lifecycleOwner) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📢 To Reviewers