Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR/#220] 공고 상세 뷰 / 리팩토링 #230

Merged
merged 15 commits into from
Sep 9, 2024
Merged

[REFACTOR/#220] 공고 상세 뷰 / 리팩토링 #230

merged 15 commits into from
Sep 9, 2024

Conversation

arinming
Copy link
Contributor

@arinming arinming commented Sep 9, 2024

⛳️ Work Description

  • 매퍼 생성
  • 네비게이터 변경
  • 다이얼로그 로직 수정

📸 Screenshot

220.mp4

📢 To Reviewers

  • Scaffold를 삭제하고 Column으로 변경하면서 바텀바가 적용이 뭔가 어색해지는데 더 연구해보겠습니다 ㅜㅜ,.,. 다이얼로그도 연결은 했는데, 스크랩 추가시 토큰을 재발급하면서 401 에러가 발생하고 추가가 되지 않아서 해당 안건 문의 드립니다 🥹🥹🥹🥹🥹🥹

@arinming
[MOVE/#220] InternInfoModel 패키지 이동
24fee25
@arinming
[RENAME/#220] InternInfoModel -> InternInfo 리네임
71fcac1
@arinming
[FEAT/#220] InternInfoMapper 생성
cc8b5d5
@arinming
[FEAT/#220] InternInfoMapper 연결
2e3023e
@arinming
Merge remote-tracking branch 'origin/develop' into refactor/#220-anno…
6babcdf 
…uncement
@arinming
[FEAT/#220] Scaffold 삭제
29ef0a5
@arinming
[FEAT/#220] paddingValues 추가
6646fb6
@arinming
[FEAT/#220] 공고 상세 페이지 패딩 값 조절
fdd3033
@arinming
[FEAT/#220] 공고 상세 페이지 스크랩 다이어로그 띄우기
2dfd5b7
@arinming
Merge remote-tracking branch 'origin/develop' into refactor/#220-anno…
be0679b 
…uncement

# Conflicts:
#	feature/src/main/java/com/terning/feature/dialog/detail/ScrapDialog.kt
#	feature/src/main/java/com/terning/feature/intern/InternViewModel.kt
@arinming
[FEAT/#220] 공고 상세 페이지 스크랩 다이얼로그 구분
011571f
@arinming arinming added UI 💐 UI 작업 아린💛 아린 labels Sep 9, 2024
@arinming arinming added this to the 2차 스프린트 작업 milestone Sep 9, 2024
@arinming arinming self-assigned this Sep 9, 2024
@arinming arinming linked an issue Sep 9, 2024 that may be closed by this pull request
[REFACTOR] 공고 상세 뷰 / 리팩토링 #220
Closed
4 tasks
boiledEgg-s
boiledEgg-s requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~
스크랩 문제는 서버에서 현재 색상값을 문자열로 받도록 API를 수정했는데 그걸 반영하지 못해 생긴 것 같습니다,,
최대한 빨리 반영하고 PR 올리테니 그거 먼저 머지하고 여기에 반영해서 확인하고 다시 리뷰 요청 부탁드려요!!

@boiledEgg-s
Copy link
Member

그리고 메인 검색 화면의 탑바 좌측에 로고는 왜 초록색 박스로 나오는 건가요??

@arinming
Copy link
Contributor Author

arinming commented Sep 9, 2024

그리고 메인 검색 화면의 탑바 좌측에 로고는 왜 초록색 박스로 나오는 건가요??

스크랩 문제 확인했습니다!
메인 검색 화면은 패딩value 적용 아직 안된 상태라 따로 이슈 파서 수정할 예정입니당

leeeyubin
leeeyubin approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니당~!! 리팩 넘넘 좋아용!!!!

feature/src/main/java/com/terning/feature/main/MainScreen.kt
Comment on lines +165 to +168
internNavGraph(
paddingValues = paddingValues,
navHostController = navigator.navController
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

적용 좋아요!!!

@boiledEgg-s boiledEgg-s merged commit c326c31 into develop Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeeyubin leeeyubin leeeyubin approved these changes

@boiledEgg-s boiledEgg-s boiledEgg-s approved these changes

@Hyobeen-Park Hyobeen-Park Awaiting requested review from Hyobeen-Park

Assignees

@arinming arinming

Labels
UI 💐 UI 작업 아린💛 아린
Projects
Terning-Android
Status: Done
Milestone
2차 스프린트 작업
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 공고 상세 뷰 / 리팩토링
3 participants
@arinming @boiledEgg-s @leeeyubin