-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI/#204] 홈 뷰 / UI 수정사항 반영 및 리팩토링 #232
Merged
+953
−1,544
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
3c3cdd5
[UI/#204] 홈 뷰 곧 마감되는 공고 아이템 수정
Hyobeen-Park 2ae81c5
[UI/#204] 홈 뷰 곧 마감되는 공고 아이템 padding 값 수정
Hyobeen-Park 879e51f
[UI/#204] 홈 뷰 필터링 버튼 수정
Hyobeen-Park 11b4442
[UI/#204] 홈 뷰 필터링 정보 수정
Hyobeen-Park 50ab00e
Merge remote-tracking branch 'origin/develop' into ui/#204-home-view
Hyobeen-Park 85ccbe4
[CHORE/#204] 변수명 및 함수 파라미터 수정
Hyobeen-Park b5b99f0
[UI/#204] divider 삭제
Hyobeen-Park 61496e0
[UI/#204] 정렬버튼 컴포넌트 패딩 수정
Hyobeen-Park e885a11
[UI/#204] 공고 개수 표시 UI 구현
Hyobeen-Park 6318b9a
[UI/#204] theme 색상 추가
Hyobeen-Park edc307f
[UI/#204] domain/type에 enum class 추가
Hyobeen-Park f67afb8
[UI/#204] string 수정
Hyobeen-Park 356d985
[UI/#204] 필터링 재설정 바텀시트 구현
Hyobeen-Park b329364
[UI/#204] 필터링 재설정 화면 버튼 색상 수정
Hyobeen-Park 384fe8e
[UI/#204] 바텀시트 관련 로직 수정
Hyobeen-Park 28f8b72
[DELETE/#204] 기존 필터링 재설정 뷰 삭제
Hyobeen-Park 735354d
Merge remote-tracking branch 'origin/develop' into ui/#204-home-view
Hyobeen-Park ca9f314
[UI/#204] 필터링 정보 표시
Hyobeen-Park f0ae573
[MOD/#204] enum class 패키지 이동 및 파라미터 수정
Hyobeen-Park 5327a86
[MOD/#204] 곧 마감되는 공고 서버통신 수정
Hyobeen-Park 8a58059
[CHORE/#204] 패키지 이동
Hyobeen-Park 91f8762
Merge remote-tracking branch 'origin/develop' into ui/#204-home-view
Hyobeen-Park 33d3dd3
[REFACTOR/#204] 맞춤 공고 API 수정사항 반영
Hyobeen-Park 76521ad
[CHORE/#204] 근무 기간 enum 수정
Hyobeen-Park f8718ff
Merge remote-tracking branch 'origin/develop' into ui/#204-home-view
Hyobeen-Park b3f3efb
[MOD/#204] enum 함수 추가
Hyobeen-Park a58d6b0
[REFACTOR/#204] 필터링 재설정 API 수정사항 반영
Hyobeen-Park 8a72727
[REFACTOR/#204] 곧 마감 정보 리팩토링
Hyobeen-Park 0907e8a
[CHORE/#204] test style 적용
Hyobeen-Park aaadc13
[REFACTOR/#204] 곧 마감 공고 로직 수정
Hyobeen-Park 6a02360
[CHORE/#204] 코드 정리
Hyobeen-Park 58b7425
[CHORE/#204] 필터링 인덱스 int로 수정
Hyobeen-Park 631ec67
Merge remote-tracking branch 'origin/develop' into ui/#204-home-view
Hyobeen-Park 1cfe864
[FEAT/#204] 맞춤 공고 스크랩 다이얼로그 연결
Hyobeen-Park e849735
[FEAT/#204] 곧 마감 공고 스크랩 다이얼로그 연결
Hyobeen-Park a4b1cab
[DELETE/#204] 기존 홈 뷰 다이얼로그 삭제
Hyobeen-Park f3ba7bc
[MOD/#204] 데이트피커 수정
Hyobeen-Park 27adb74
[CHORE/#204] string 추출
Hyobeen-Park 2c207d9
[CHORE/#204] 함수 전달 방식 수정
Hyobeen-Park 34f73a8
[CHORE/#204] 색상 수정
Hyobeen-Park f103667
Merge remote-tracking branch 'origin/develop' into ui/#204-home-view
Hyobeen-Park ec25157
[FEAT/#204] 버튼 캘린더로 연결
Hyobeen-Park File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 0 additions & 12 deletions
12
core/src/main/java/com/terning/core/designsystem/component/bottomsheet/SortBy.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
package com.terning.core.type | ||
|
||
import androidx.annotation.StringRes | ||
import com.terning.core.R | ||
|
||
enum class Grade( | ||
val stringValue: String, | ||
@StringRes val stringResId: Int, | ||
) { | ||
FRESHMAN("freshman", R.string.change_filter_grade_1), | ||
SOPHOMORE("sophomore", R.string.change_filter_grade_2), | ||
JUNIOR("junior", R.string.change_filter_grade_3), | ||
SENIOR("senior", R.string.change_filter_grade_4); | ||
|
||
companion object { | ||
fun fromString(value: String?): Grade = when (value) { | ||
"freshman" -> FRESHMAN | ||
"sophomore" -> SOPHOMORE | ||
"junior" -> JUNIOR | ||
"senior" -> SENIOR | ||
else -> FRESHMAN | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package com.terning.core.type | ||
|
||
import androidx.annotation.StringRes | ||
import com.terning.core.R | ||
|
||
enum class SortBy( | ||
@StringRes val sortBy: Int, | ||
val type: String, | ||
) { | ||
EARLIEST(R.string.sort_by_earliest, "deadlineSoon"), | ||
SHORTEST(R.string.sort_by_shortest, "shortestDuration"), | ||
LONGEST(R.string.sort_by_longest, "longestDuration"), | ||
SCRAP(R.string.sort_by_scrap, "mostScrapped"), | ||
VIEW_COUNT(R.string.sort_by_view_count, "mostViewed"), | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
package com.terning.core.type | ||
|
||
import androidx.annotation.StringRes | ||
import com.terning.core.R | ||
|
||
enum class WorkingPeriod( | ||
val stringValue: String, | ||
@StringRes val stringResId: Int, | ||
) { | ||
SHORT("short", R.string.change_filter_period_1), | ||
MIDDLE("middle", R.string.change_filter_period_2), | ||
LONG("long", R.string.change_filter_period_3); | ||
|
||
companion object { | ||
fun fromString(value: String?): WorkingPeriod = when (value) { | ||
"short" -> SHORT | ||
"middle" -> MIDDLE | ||
"long" -> LONG | ||
else -> SHORT | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 5 additions & 5 deletions
10
...data/mapper/home/HomeTodayInternMapper.kt → ...a/mapper/home/HomeUpcomingInternMapper.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,17 @@ | ||
package com.terning.data.mapper.home | ||
|
||
import com.terning.data.dto.response.HomeTodayInternResponseDto | ||
import com.terning.domain.entity.home.HomeTodayIntern | ||
import com.terning.data.dto.response.HomeUpcomingInternResponseDto | ||
import com.terning.domain.entity.home.HomeUpcomingIntern | ||
|
||
fun HomeTodayInternResponseDto.toHomeTodayInternList(): HomeTodayIntern = | ||
HomeTodayIntern( | ||
scrapId = this.scrapId, | ||
fun HomeUpcomingInternResponseDto.toHomeUpcomingInternList(): HomeUpcomingIntern = | ||
HomeUpcomingIntern( | ||
internshipAnnouncementId = this.internshipAnnouncementId, | ||
companyImage = this.companyImage, | ||
title = this.title, | ||
dDay = this.dDay, | ||
deadline = this.deadline, | ||
workingPeriod = this.workingPeriod, | ||
isScrapped = this.isScrapped, | ||
startYearMonth = this.startYearMonth, | ||
color = this.color, | ||
) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
단순 궁금증인데 value 값이 nullable인 이유가 궁금해요..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사용자 필터링 정보가 없을 때 null로 저장이 돼서 nullable하게 만들었습니다!! null 처리를 screen에서 하니까 코드가 너무 복잡해지더라구요😅