Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/#229] 검색 뷰 / UI 수정 #234

Merged
merged 8 commits into from
Sep 9, 2024
Merged

[UI/#229] 검색 뷰 / UI 수정 #234

merged 8 commits into from
Sep 9, 2024

Conversation

arinming
Copy link
Contributor

@arinming arinming commented Sep 9, 2024

⛳️ Work Description

  • 검색 초기 화면 UI 수정
  • 검색 결과 없는 화면 UI 수정
  • 검색 결과 있는 화면 UI 수정

📸 Screenshot

229.mp4

📢 To Reviewers

  • 스크랩이나 필터링 등 로직 관련된 건 리팩 이슈 올려서 빠른 시일 내에 수정하게씁니다...! 🥹

@arinming arinming added UI 💐 UI 작업 아린💛 아린 labels Sep 9, 2024
@arinming arinming added this to the 2차 스프린트 작업 milestone Sep 9, 2024
@arinming arinming self-assigned this Sep 9, 2024
@arinming arinming linked an issue Sep 9, 2024 that may be closed by this pull request
3 tasks
Copy link
Member

@boiledeggg boiledeggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리팩 깔끔하네요~!! 너무 고생하셨습니다~~

Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 피알 무슨 일이에요 ㄷㄷ 짱아린언니 수고했어요!!!!

@@ -72,6 +70,7 @@ fun SearchRoute(
}

SearchScreen(
modifier = modifier,
Copy link
Member

@leeeyubin leeeyubin Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

취향차이일순 있는데 Route에서 Screen을 선언할 때 modifier를 사용할 일이 없다면 매개변수로 전해주지 않아도 될 것 같다는 생각이 들긴하네용

Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

캬~ 깔끔하네욤 수고하셨습니다👍🏻

@leeeyubin
Copy link
Member

캬~ 깔끔하네욤 수고하셨습니다👍🏻

@leeeyubin leeeyubin closed this Sep 9, 2024
@leeeyubin leeeyubin reopened this Sep 9, 2024
@boiledeggg boiledeggg merged commit 47cc383 into develop Sep 9, 2024
1 check passed
@boiledeggg
Copy link
Member

이 PR을 머지하는 영광은 제가 가져갑니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 💐 UI 작업 아린💛 아린
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[UI] 검색 뷰 / UI 수정
4 participants