[REFACTOR/#246] 달력 로직 대폭 수정 #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
Sep 14, 2024
Comment on lines
+31
to
38
| fun updateCurrentDate(date: LocalDate) = | ||
| viewModelScope.launch { | ||
| _uiState.update { currentState -> | ||
| currentState.copy( | ||
| currentDate = date | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
오 여기에 viewModelScope.launch가 추가된 이유가 궁금해요!
There was a problem hiding this comment.
추가 당시엔 별 이유는 없고, 조금이나마 성능에 도움이 될까봐 추가했어요ㅎㅎ
근데 그닥 필요한 건 아닌 것 같네요,,
arinming
approved these changes
Sep 15, 2024
Comment on lines
+88
to
+89
| CompositionLocalProvider( | ||
| LocalPagerState provides pagerState |
There was a problem hiding this comment.
특정 컴포저블의 하위 컴포저블에서 변수를 전역으로 사용할 수 있게끔 해주는 CompositionLocal입니다!
PagerState로 이전하면서 매 컴포저블마다 매개변수로 넣는 것 보다 그냥 CompositionLocal로 구현해봤습니다~
Comment on lines
+14
to
+16
| val LocalPagerState = compositionLocalOf<PagerState> { | ||
| error("No PagerState provided") | ||
| } |
There was a problem hiding this comment.
요 부분 하드코딩하신 이유가 따로 있으신가용?!
There was a problem hiding this comment.
UI적으로 필요한 부분이 아니라 그냥 하드코딩으로 넣어놨습니다!
딱히 재사용되는 것도 아니라 리소스화할 필요성을 못느꼈는데 저런 부분도 리소스화해야 할까요??
Comment on lines
+48
to
+50
| snapshotFlow { pagerState.currentPage } | ||
| .collect { currentPage-> | ||
| viewModel.getScrapMonth(currentPage) |
Hyobeen-Park
approved these changes
Sep 15, 2024
| onClickListButton: () -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| val coroutineScope = rememberCoroutineScope() | ||
|
|
||
| val listState = rememberLazyListState( | ||
| initialFirstVisibleItemIndex = uiState.calendarModel.initialPage | ||
| val pagerState = rememberPagerState( |
Comment on lines
+86
to
+87
| UiState.Loading -> emptyMap() | ||
| UiState.Empty -> emptyMap() |
There was a problem hiding this comment.
Loading이랑 Empty는 앞에 is를 안붙여도 되는군요....!😮 처음 알았어요ㅎㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
KakaoTalk_Video_2024-09-14-19-34-13.mp4
📢 To Reviewers
기존엔 "월간 -> 주간 -> 목록 -> 월간"으로 전환이 됐다면, 이젠 "월간 -> 주간 -> 목록 -> 주간"으로 전환이 이뤄집니다!