[FIX/#239] 공고 상세 뷰 / QA 수정사항 반영 #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
arinming
changed the title
leeeyubin
reviewed
Sep 14, 2024
There was a problem hiding this comment.
제가 아린언니 브렌치 들어가서 돌려봤는데 실기기 문제인 것 같아요..! 공기계로 돌려보니 안 뜨더라구요ㅜㅜ
130번째 줄에 아래와 같이 수정하면 웹 뷰 잘 뜨는 것 같습니당..!
확인부탁드려요!
val context = LocalContext.current
if (internUiState.showWeb) {
CustomTabsIntent.Builder().build().launchUrl(context,internInfo.url.toUri())
}
There was a problem hiding this comment.
추가로.. 제가 말한대로 작성 시 백버튼 눌렀을 때 다시 웹 뷰가 뜨는 이슈가 있는 것 같은데,, 저도 정확히 보지 않아서 뭐가 문제인지 확실하진 않지만,, 이 부분은 MyPageRoute 한번 참고해보면 좋을 것 같아요..!
There was a problem hiding this comment.
새삼스럽지만 사랑합니다 ㅜㅜ
수정했는데, 실기기에서 잘 동작하는지 확인해주심 감사 🥹
There was a problem hiding this comment.
확인했습니당 잘 동작하네요!! 수고했어요!!🙂 @arinming
Comment on lines
144
to
+149
| Column( | ||
| modifier = modifier.fillMaxHeight(), | ||
| modifier = modifier | ||
| .statusBarsPadding() | ||
| .navigationBarsPadding() | ||
| .fillMaxHeight() | ||
| .background(White), |
boiledEgg-s
approved these changes
Sep 15, 2024
Hyobeen-Park
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
239.mp4
📢 To Reviewers