[FIX/#247] 홈 뷰 / 추가 수정사항 반영 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/java/com/terning/core/designsystem/component/bottomsheet/SortingBottomSheet.kt
leeeyubin
approved these changes
Sep 21, 2024
Comment on lines
399
to
410
| with(homeUpcomingInternState.data) { | ||
| if (!hasScrapped) { | ||
| HomeUpcomingEmptyFilter() | ||
| } else if (homeUpcomingInternDetail.isEmpty()) { | ||
| HomeUpcomingEmptyIntern(navigateToCalendar = navigateToCalendar) | ||
| } else { | ||
| HomeUpcomingInternScreen( | ||
| internList = homeUpcomingInternDetail, | ||
| homeState = homeState, | ||
| navigateToIntern = navigateToIntern | ||
| ) | ||
| } |
There was a problem hiding this comment.
개인적으로 저는 조건문이 3개 이상인 경우는 when문으로 사용하는 것이 좀 더 코틀린스러워서 그렇게 하고 있답니당 참고만해주세요!
There was a problem hiding this comment.
앗하 지금보니 when문 사용하는게 훨씬 더 낫겠네요!!! 감사합니다💗
Comment on lines
210
to
219
| viewModel.updateRecommendDialogVisibility(false) | ||
| if (it) { | ||
| viewModel.getRecommendInternsData( | ||
| sortBy = homeState.sortBy.ordinal, | ||
| startYear = homeFilteringInfo.startYear | ||
| ?: Calendar.getInstance().currentYear, | ||
| startMonth = homeFilteringInfo.startMonth | ||
| ?: Calendar.getInstance().currentMonth, | ||
| ) | ||
| viewModel.getHomeUpcomingInternList() |
There was a problem hiding this comment.
나중에 리팩할 때 뷰모델 관련 로직은 screen 함수랑 분리해보는 것도 좋을 것 같아요..!
There was a problem hiding this comment.
오호!! 너무 좋아요!!! 다이얼로그 내부 함수들을 분리해줬더니 홈 뷰의 컴포넌트에서도 뷰모델에 대한 의존성이 사라졌어요!! 감사합니다😊
boiledEgg-s
approved these changes
Sep 21, 2024
| startMonth = homeFilteringInfo.startMonth | ||
| ?: Calendar.getInstance().currentMonth, | ||
| ) | ||
| if (it) { |
There was a problem hiding this comment.
람다에 변수가 있을 땐 이름을 붙여주면 코드가 더 직관적이고 잘 읽히더라구요!
지금같이 it을 쓰는 것보단 쓰임새에 맞게 이름을 붙여주는걸 습관화하면 좋을 것 같아요~~
There was a problem hiding this comment.
흐어 아직도 이렇게 이름 안붙이고 놓치는 부분이 있네여🫠 알려주셔서 감사합니다😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240922_041843_terning.mp4
📢 To Reviewers