Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX/#264] 온보딩 뷰 / 2차 QA 반영 #266

Merged
merged 10 commits into from
Sep 27, 2024
Merged

Conversation

leeeyubin
Copy link
Member

⛳️ Work Description

  • 로그인 뷰에 그래픽 적용
  • 카카오 로그인 버튼 위치 수정
  • 이름 설정 텍스트 필드 조건 수정

📸 Screenshot

Screen_Recording_20240926_134121_terning.mp4

📢 To Reviewers

  • 2차 QA 화이팅~

@leeeyubin leeeyubin added FIX 🔨 버그 및 오류 해결 유빈💙 유빈 labels Sep 26, 2024
@leeeyubin leeeyubin added this to the 2차 스프린트 작업 milestone Sep 26, 2024
@leeeyubin leeeyubin self-assigned this Sep 26, 2024
Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고핑!!!!! 수고했어욥

Comment on lines +41 to +44
Image(
painter = painterResource(R.drawable.ic_signin_kakao),
modifier = Modifier.padding(horizontal = 8.dp),
contentDescription = "kakao login icon"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contentDescription는 의도하신건가엽?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵..! 관련 설명 써주면 좋을 것 같아서 넣었습니다:)

Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨슴다~ lgtm~~

Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우왕 수고하셨습니당~~!! LGTM~~

@leeeyubin leeeyubin merged commit 96e03d6 into develop Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIX 🔨 버그 및 오류 해결 유빈💙 유빈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 온보딩 뷰 / 2차 QA 반영
4 participants