-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX/#267] 탐색 뷰 / 2차 QA 반영 #269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니당~~ LGTM~~!!
인스타 QA 저도 실기기로 했을 때 잘 됩니다..!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생 많으셨슴다~~ 저도 제 폰으로 확인해봤을 때 인스타는 잘 뜨네요!
@@ -27,21 +27,34 @@ fun ImageSlider( | |||
images: List<Int>, | |||
onAdvertisementClick: () -> Unit, | |||
) { | |||
val pagerState = rememberPagerState(pageCount = { images.size }) | |||
val infiniteImages = remember { images + images + images } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
왜 동일한 리스트가 3번 더해진건가요?
배너에 이미지가 무조건 3개 이상 있도록 하려고 이렇게 구현하신건가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 저렇게 해야 좌우로 이동할 때 부드럽게 이동되더라구요..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인이요!! 수고했습니당
⛳️ Work Description
📸 Screenshot
267.mp4
📢 To Reviewers