Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX/#267] 탐색 뷰 / 2차 QA 반영 #269

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Conversation

arinming
Copy link
Contributor

⛳️ Work Description

  • 배너 무한 스크롤
  • 공고 상세 페이지 qa 반영
  • 탐색 메인 qa 반영

📸 Screenshot

267.mp4

📢 To Reviewers

  • 인스타 관련 qa 하나 남았는데, 이 부분은 우연이랑 저는 잘 돼서 혹시 안드 실기기로 확인해주심 감사하겠어용,.! 🥹🥹🥹🥹🥹🥹

@arinming arinming added FIX 🔨 버그 및 오류 해결 아린💛 아린 labels Sep 26, 2024
@arinming arinming added this to the 2차 스프린트 작업 milestone Sep 26, 2024
@arinming arinming self-assigned this Sep 26, 2024
@arinming arinming linked an issue Sep 26, 2024 that may be closed by this pull request
3 tasks
Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당~~ LGTM~~!!

@Hyobeen-Park
Copy link
Member

인스타 QA 저도 실기기로 했을 때 잘 됩니다..!!

Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨슴다~~ 저도 제 폰으로 확인해봤을 때 인스타는 잘 뜨네요!

@@ -27,21 +27,34 @@ fun ImageSlider(
images: List<Int>,
onAdvertisementClick: () -> Unit,
) {
val pagerState = rememberPagerState(pageCount = { images.size })
val infiniteImages = remember { images + images + images }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왜 동일한 리스트가 3번 더해진건가요?
배너에 이미지가 무조건 3개 이상 있도록 하려고 이렇게 구현하신건가요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 저렇게 해야 좌우로 이동할 때 부드럽게 이동되더라구요..!

Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인이요!! 수고했습니당☺️

@leeeyubin leeeyubin merged commit f6f7dc7 into develop Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIX 🔨 버그 및 오류 해결 아린💛 아린
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FIX] 탐색 뷰 / 2차 QA 반영
4 participants