Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX/#274] 온보딩, 마이페이지 / 최종 QA #277

Merged
merged 9 commits into from
Oct 6, 2024
Merged

[FIX/#274] 온보딩, 마이페이지 / 최종 QA #277

merged 9 commits into from
Oct 6, 2024

Conversation

leeeyubin
Copy link
Member

@leeeyubin leeeyubin commented Oct 4, 2024 •
edited
Loading

⛳️ Work Description

  • 이름 -> 닉네임
  • 마이페이지 버전 정렬
  • 아이콘 에셋 설정
  • 공고상세페이지 이미지 수정
  • 버전 업데이트 -> 1.1.2

📸 Screenshot

바꾸기 전 바꾼 후

📢 To Reviewers

  • 최종 QA 반영했습니다!
  • 개인적으로 받은 피드백 중에 에셋 설정 잘못되어 있다는 것이 있었어서 같이 바꿔줬어요!

@leeeyubin leeeyubin added FIX 🔨 버그 및 오류 해결 유빈💙 유빈 labels Oct 4, 2024
@leeeyubin leeeyubin added this to the 2차 스프린트 작업 milestone Oct 4, 2024
@leeeyubin leeeyubin self-assigned this Oct 4, 2024
boiledEgg-s
boiledEgg-s approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최종 QA까지 너무 고생많았어요~!! 되게 LGTM입니당

arinming
arinming approved these changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

끝까지 최고 ㅜㅜ 다운그레이드 확인했습니다!

Hyobeen-Park
Hyobeen-Park approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

룩베리굿투미~~

feature/src/main/java/com/terning/feature/mypage/mypage/component/MyPageItem.kt
@@ -38,8 +40,9 @@ fun MyPageItem(
Row(
verticalAlignment = Alignment.CenterVertically
) {
TerningImage(
painter = icon,
Image(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오!! 요것도 바꿔주셨군요!!!!

@leeeyubin leeeyubin merged commit c6e09dc into develop Oct 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boiledEgg-s boiledEgg-s boiledEgg-s approved these changes

@Hyobeen-Park Hyobeen-Park Hyobeen-Park approved these changes

@arinming arinming arinming approved these changes

Assignees

@leeeyubin leeeyubin

Labels
FIX 🔨 버그 및 오류 해결 유빈💙 유빈
Projects
None yet
Milestone
2차 스프린트 작업
Development

Successfully merging this pull request may close these issues.

[FIX] 온보딩, 마이페이지 / 최종 QA
4 participants
@leeeyubin @arinming @Hyobeen-Park @boiledEgg-s