Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD/#28] CustomShadow 구현 #29

Merged
merged 4 commits into from
Jul 10, 2024
Merged

[ADD/#28] CustomShadow 구현 #29

merged 4 commits into from
Jul 10, 2024

Conversation

Hyobeen-Park
Copy link
Member

⛳️ Work Description

  • 그림자 색상 변경 가능
  • 그림자 radius 변경 가능
  • 그림자 width 지정 가능

📸 Screenshot

📢 To Reviewers

  • 패키지 구조 어떤지 한번만 봐주세요!!
  • 사용할 때는 color, shadowRadius, shadowWidth 지정해주면 되고 기본값은 각각 Grey200, 0.dp, 2.dp로 지정되어 있습니다 (아마도 가장 많이 사용하는게 Grey200, 2.dp라고 하셔서 기본값으로 설정해뒀어요..!!)

@Hyobeen-Park Hyobeen-Park added ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 효빈💚 효빈 labels Jul 9, 2024
@Hyobeen-Park Hyobeen-Park self-assigned this Jul 9, 2024
leeeyubin
leeeyubin approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어려운 것도 척척해내는 효빈언니 최고!!!

core/src/main/java/com/terning/core/designsystem/component/modifier/ShadowModifier.kt Outdated
Comment on lines 1 to 4
package com.terning.core.designsystem.component.modifier

import android.graphics.BlurMaskFilter
import androidx.compose.runtime.Composable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifier의 확장함수면 core>extension에 있는 Modifier.kt 파일에 넣는 게 좋을 것 같아요!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어머어머 세상에 Modifier 이미 있는거 깜빡했네요😅 감사해용!!

boiledEgg-s
boiledEgg-s approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 제가 포기한건데 뚝딱 해내시다니,,, 진짜 최곱니다!!!

arinming
arinming approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그림자 요긴하게 잘 써먹겠습니다 ㅜㅜ!!!!!!

@Hyobeen-Park Hyobeen-Park merged commit 4f6846c into develop Jul 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeeyubin leeeyubin leeeyubin approved these changes

@boiledEgg-s boiledEgg-s boiledEgg-s approved these changes

@arinming arinming arinming approved these changes

Assignees

@Hyobeen-Park Hyobeen-Park

Labels
ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 효빈💚 효빈
Projects
None yet
Milestone
1차 스프린트 UI 작업
Development

Successfully merging this pull request may close these issues.

[ADD] Shadow 컴포넌트 구현
4 participants
@Hyobeen-Park @arinming @boiledEgg-s @leeeyubin