Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOD/#298] 배너 이미지 변경 #299

Merged
merged 7 commits into from
Oct 23, 2024
Merged

[MOD/#298] 배너 이미지 변경 #299

merged 7 commits into from
Oct 23, 2024

Conversation

boiledEgg-s
Copy link
Member

@boiledEgg-s boiledEgg-s commented Oct 23, 2024

⛳️ Work Description

  • 배너 이미지 변경
  • 배너용 엔티티 생성
  • 배너별 링크 적용을 위한 코드 리팩토링
  • 버전 업데이트

📸 Screenshot

241023_.mp4

📢 To Reviewers

  • 배너 추가 완료입니다~
  • 코드가 수정할 부분이 생겨서 조금 손을 댔어요! 확인 부탁스

@boiledEgg-s boiledEgg-s added MOD ✅ 코드 수정 및 내부 파일 수정 UI 💐 UI 작업 석준💜 석준 labels Oct 23, 2024
@boiledEgg-s boiledEgg-s self-assigned this Oct 23, 2024
Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

캬~ 배너 수정 고마워요!! 수고하셨습니다😊

@@ -0,0 +1,6 @@
package com.terning.domain.entity.search

data class SearchBanner(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호~~~~ data class 추가한거 좋네요!!

Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아주 깔꼼스해서 베리 만족입니다 수정 감사해요!

Comment on lines +5 to +6
versionName = "1.1.7"
versionCode = "10107"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

업데이트 감사합니다~

Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

외쳐 갓석준. 확인했습니다~

@boiledEgg-s boiledEgg-s merged commit 4022be5 into develop Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MOD ✅ 코드 수정 및 내부 파일 수정 UI 💐 UI 작업 석준💜 석준
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MOD] 배너 이미지 변경
3 participants