[UI/#11] 탐색 뷰 / 탐색 기본 화면 구현 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # feature/src/main/java/com/terning/feature/search/SearchRoute.kt
# Conflicts: # feature/src/main/java/com/terning/feature/main/MainNavigator.kt
Closed
5 tasks
boiledEgg-s
approved these changes
Jul 10, 2024
| ) | ||
|
|
||
| SearchInternList(type = "view") |
There was a problem hiding this comment.
"view"와 "scrap"이 화면에 표시할 인턴 공고 타입을 나타내는 문자열 같은데 이건 enum과 같은 것으로 카테고리화하는게 좋아보이네요!!
There was a problem hiding this comment.
꺅!!!!!!!섬세하시다. 적용킵고잉하겠습니다
Comment on lines
+30
to
+36
| LaunchedEffect(Unit) { | ||
| while (true) { | ||
| delay(3000) | ||
| val nextPage = (pagerState.currentPage + 1) % pagerState.pageCount | ||
| pagerState.scrollToPage(nextPage) | ||
| } | ||
| } |
There was a problem hiding this comment.
우왕 자동 스크롤까지 구현하다니!!! 진짜 최고최고
There was a problem hiding this comment.
기디에서 3초마다 넘어가게 해달라고 하셔서 반영했습니당....... 🫶🏻
Hyobeen-Park
approved these changes
Jul 10, 2024
|
|
||
| Text( | ||
| text = stringResource(id = R.string.search_today_popular), | ||
| modifier = Modifier.padding(horizontal = 16.dp, vertical = 4.dp), |
There was a problem hiding this comment.
여기 padding horizontal = 24.dp 인 것 같아요!
There was a problem hiding this comment.
전체 패딩값이 24.dp 였군요 ㅠ ㅠ 당장 수정할게욥
Comment on lines
+30
to
+36
| LaunchedEffect(Unit) { | ||
| while (true) { | ||
| delay(3000) | ||
| val nextPage = (pagerState.currentPage + 1) % pagerState.pageCount | ||
| pagerState.scrollToPage(nextPage) | ||
| } | ||
| } |
There was a problem hiding this comment.
우왕 자동 스크롤까지 구현하다니!!! 진짜 최고최고
leeeyubin
approved these changes
Jul 10, 2024
Comment on lines
11
to
16
| fun SearchTextField( | ||
| text: String, | ||
| onValueChange: (String) -> Unit, | ||
| readOnly: Boolean = false, | ||
| hint: String, | ||
| leftIcon: Int, |
There was a problem hiding this comment.
요거 readOnly를 젤 아래로 내려줘야 할 것 같아용
Comment on lines
+58
to
+63
| contentDescription = null, | ||
| modifier = modifier | ||
| .fillMaxWidth() | ||
| .height(112.dp) | ||
| .padding(16.dp) | ||
| ) |
There was a problem hiding this comment.
나중에 실제 광고 화면 들어가면 요거 고정 디피는 지양하면 좋을 것 가타요!
leeeyubin
approved these changes
Jul 10, 2024
# Conflicts: # core/src/main/java/com/terning/core/designsystem/component/topappbar/TerningBasicTopAppBar.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
11.mp4
📢 To Reviewers