Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT/#300] 엠플리튜드 이벤트 심기 #301

Merged
merged 4 commits into from
Nov 19, 2024
+26 −5
Merged

[FEAT/#300] 엠플리튜드 이벤트 심기 #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e497f28
[FEAT/#300] version update 1.1.7 -> 1.1.8
leeeyubin Nov 19, 2024
615ada1
[FEAT/#300] 터닝 시작하기 엠플리튜드 이벤트
leeeyubin Nov 19, 2024
ea8813e
[FEAT/#300] 탐색 배너 엠플리튜드 이벤트
leeeyubin Nov 19, 2024
01e2a50
[FEAT/#300] 다이얼로그 엠플리튜드 이벤트
leeeyubin Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion feature/src/main/java/com/terning/feature/dialog/detail/ScrapDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,13 @@ fun ScrapDialog(
)
}
},
onClickNavigateButton = viewModel::navigateToDetail,
onClickNavigateButton = {
viewModel.navigateToDetail()
amplitudeTracker.track(
type = EventType.CLICK,
name = "modal_detail"
)
},
onClickScrapButton = {
amplitudeTracker.track(
type = EventType.CLICK,
Expand Down
12 changes: 11 additions & 1 deletion feature/src/main/java/com/terning/feature/filtering/startfiltering/StartFilteringRoute.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import androidx.compose.ui.unit.dp
import androidx.hilt.navigation.compose.hiltViewModel
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.airbnb.lottie.compose.LottieConstants
import com.terning.core.analytics.EventType
import com.terning.core.analytics.LocalTracker
import com.terning.core.designsystem.component.button.RectangleButton
import com.terning.core.designsystem.component.item.TerningLottieAnimation
import com.terning.core.designsystem.theme.TerningPointTheme
Expand All @@ -44,13 +46,21 @@ fun StartFilteringRoute(
val configuration = LocalConfiguration.current
val screenHeight = 780f / configuration.screenHeightDp

val amplitudeTracker = LocalTracker.current

LaunchedEffect(key1 = true) {
delay(DELAY)
viewModel.updateButtonState()
}

StartFilteringScreen(
onNextClick = onNextClick,
onNextClick = {
onNextClick()
amplitudeTracker.track(
type = EventType.CLICK,
name = "start_service"
)
},
buttonState = state.isButtonVisible,
screenHeight = screenHeight,
)
Expand Down
7 changes: 6 additions & 1 deletion feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,12 @@ fun SearchRoute(
},
navigateToIntern = navigateToIntern,
onAdvertisementClick = { pageIndex ->
CustomTabsIntent.Builder().build().launchUrl(context, SearchViewModel.bannerList[pageIndex].url.toUri())
amplitudeTracker.track(
type = EventType.CLICK,
name = "quest_banner"
)
CustomTabsIntent.Builder().build()
.launchUrl(context, SearchViewModel.bannerList[pageIndex].url.toUri())
}
)
}
Expand Down
4 changes: 2 additions & 2 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
compileSdk = "34"
minSdk = "28"
targetSdk = "34"
versionName = "1.1.7"
versionCode = "10107"
versionName = "1.1.8"
versionCode = "10108"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

업데이트 축하!

kotlinCompilerExtensionVersion = "1.5.0"
jvmTarget = "1.8"

Expand Down