[UI/#20] 캘린더뷰 / 주간 캘린더 구현 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyobeen-Park
approved these changes
Jul 10, 2024
| val swipeDirection = (listState.firstVisibleItemIndex - currentPage).coerceIn(-1, 1).toLong() | ||
| .collect { | ||
| val swipeDirection = | ||
| (listState.firstVisibleItemIndex - currentPage).coerceIn(-1, 1).toLong() |
There was a problem hiding this comment.
오!! coerceIn() 처음 보는 것 같은데!! 새로운거 알아갑니당ㅎㅎ
| ) { | ||
| Card( | ||
| modifier = Modifier | ||
| .border(0.dp, Grey200, RoundedCornerShape(bottomStart = 20.dp, bottomEnd = 20.dp)) |
There was a problem hiding this comment.
줄바꿈 해주는게 쪼끔 더 가독성이 좋을 것 같아요!!
There was a problem hiding this comment.
border에도 named argument 달아주는 것도 좋을 것 같네용
leeeyubin
approved these changes
Jul 10, 2024
Comment on lines
+58
to
+59
| var currentDate by remember { mutableStateOf(LocalDate.now()) } | ||
| var currentPage by remember { mutableIntStateOf(listState.firstVisibleItemIndex) } |
There was a problem hiding this comment.
요거 rememberSaveable로 해야 되나 했는데 저희 서비스는 가로모드 대응 안 하기 때문에 안 바꿔도 될 것 같네용
Comment on lines
50
to
51
| ) { | ||
| val selectedDate by viewModel.selectedDate.collectAsState() |
There was a problem hiding this comment.
collectAsStateWithLifecycle()로 바꿔주세요!!
| ) { | ||
| Card( | ||
| modifier = Modifier | ||
| .border(0.dp, Grey200, RoundedCornerShape(bottomStart = 20.dp, bottomEnd = 20.dp)) |
There was a problem hiding this comment.
border에도 named argument 달아주는 것도 좋을 것 같네용
Comment on lines
+35
to
+40
| _selectedDate.update { currentState -> | ||
| currentState.copy( | ||
| selectedDate = date, | ||
| isEnabled = true | ||
| ) | ||
| } |
There was a problem hiding this comment.
update라는 속성을 사용했을 때의 이점이 궁금해졌어요..!
arinming
approved these changes
Jul 10, 2024
| ) { | ||
| val date = selectedDate.selectedDate | ||
| val monthData = MonthData(YearMonth.of(date.year, date.monthValue)) | ||
| val currentWeek = date.getWeekIndexContainingSelectedDate() |
There was a problem hiding this comment.
getWeekIndexContainingSelectedDate라는게 있군요,,,,,캘린더란,,,,,,,,
| @@ -35,5 +35,6 @@ | |||
| <string name="calendar_button_description_previous">previous</string> | |||
| <string name="calendar_button_description_next">next</string> | |||
| <string name="calendar_button_description_list">list</string> | |||
| <string name="calendar_animation_label">Calendar Transition</string> | |||
There was a problem hiding this comment.
string에 Calendar 주석 추가해주시면 좋을 것 같습니답.!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
default.mp4
📢 To Reviewers
경고: 일단 기능을 우선으로 구현을 했기 때문에 코드가 이쁘지 않을 수 있습니다.