Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD/#27] BottomSheet / 컴포넌트 구현 #34

Merged
merged 11 commits into from
Jul 10, 2024
Merged

[ADD/#27] BottomSheet / 컴포넌트 구현 #34

merged 11 commits into from
Jul 10, 2024

Conversation

leeeyubin
Copy link
Member

@leeeyubin leeeyubin commented Jul 9, 2024 •
edited
Loading

⛳️ Work Description

  • TerningBasicBottomSheet 구현
  • SignUpBottomSheet 구현
  • BaseResponse 수정

📸 Screenshot

Screen_Recording_20240710_071349_Terning-Android.mp4

📢 To Reviewers

  • 바텀시트 기본 테마랑 회원가입 바텀시트 구현했습니다~!

@leeeyubin leeeyubin added ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 유빈💙 유빈 labels Jul 9, 2024
@leeeyubin leeeyubin added this to the 1차 스프린트 UI 작업 milestone Jul 9, 2024
@leeeyubin leeeyubin self-assigned this Jul 9, 2024
boiledEgg-s
boiledEgg-s approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 고생많으셨어요!!
근데 아직 바텀시트가 닫힐 때 시스템 네비게이션 바를 침범하는 것 같은데 이건 해결이 안되는 부분인건가요???

@leeeyubin
Copy link
Member Author

너무 고생많으셨어요!! 근데 아직 바텀시트가 닫힐 때 시스템 네비게이션 바를 침범하는 것 같은데 이건 해결이 안되는 부분인건가요???

넹ㅜㅜ 요게 컴포즈 바텀시트의 자체의 문제인 것 같아서 일단은 이렇게 두고 추후에 해결해봐야 할 것 같아요

Hyobeen-Park
Hyobeen-Park approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바텀시트 만든거 최고다!! 최고갓기 이유빈 짱이다!! 수고하셨습니당~!

@leeeyubin leeeyubin merged commit 8ad328a into develop Jul 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boiledEgg-s boiledEgg-s boiledEgg-s approved these changes

@Hyobeen-Park Hyobeen-Park Hyobeen-Park approved these changes

@arinming arinming Awaiting requested review from arinming

Assignees

@leeeyubin leeeyubin

Labels
ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 유빈💙 유빈
Projects
None yet
Milestone
1차 스프린트 UI 작업
Development

Successfully merging this pull request may close these issues.

[ADD] BottomSheet / 컴포넌트 구현
3 participants
@leeeyubin @Hyobeen-Park @boiledEgg-s