[UI/#14] 회원가입 뷰 / UI 구현 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into ui/#14-on-boarding
Hyobeen-Park
approved these changes
Jul 11, 2024
Comment on lines
+55
to
+62
| const val NAME_ERROR = "[!@#\$%^&*(),.?\":{}|<>\\[\\]\\\\/]" | ||
| const val HELPER = "12자리 이내, 문자/숫자 가능, 특수문자/기호 입력불가" | ||
| private const val MAX_LENGTH = 12 | ||
| private const val HELPER_ERROR = "이름에 특수문자는 입력할 수 없어요" | ||
| private const val HELPER_AVAILABLE = "이용 가능한 이름이에요" | ||
| } | ||
| } |
There was a problem hiding this comment.
여기도 string으로 빼는게 가능할까요?? 가능하다면 string 분리하는게 더 좋을 것 같아서요...!
There was a problem hiding this comment.
저도 그렇게 생각하는데 뷰모델에서 제대로 추출이 안 돼서,, 추후에 더 해보겠습니당
|
|
||
| fun isInputValid(name: String) { | ||
| val nameErrorRegex = Regex(NAME_ERROR) |
arinming
approved these changes
Jul 11, 2024
Comment on lines
+33
to
+36
| signUpViewModel: SignUpViewModel = hiltViewModel(), | ||
| navController: NavController | ||
| ) { | ||
| val signUpState by signUpViewModel.state.collectAsStateWithLifecycle() |
There was a problem hiding this comment.
SignUpScreen이 아니라 SignUpRoute에서 뷰모델을 생성해서 넘기는 이유가 있나용!?? .....진짜모름
There was a problem hiding this comment.
저는 화면을 그리는 UI하고 다른 로직을 적는 걸 분리하고 싶어서 SignUpRoute에서 생성했었습니다!
나중에 성공했을 때의 로직만 screen으로 넘기도록 리팩해볼게요!
Comment on lines
+105
to
+108
| onValueChange = { name -> | ||
| signUpViewModel.isInputValid(name) | ||
| }, |
There was a problem hiding this comment.
뷰모델 네이밍 방식 통일해야 할 것 같은데 얘기해보면 좋을 것 같습니당!~!~~! ~~~!
Comment on lines
26
to
51
| name = trimmedName, | ||
| drawLineColor = WarningRed, | ||
| helper = HELPER_ERROR, | ||
| helperIcon = R.drawable.ic_sign_up_error, | ||
| helperColor = WarningRed, | ||
| isButtonValid = false | ||
| ) | ||
|
|
||
| trimmedName.isEmpty() -> _state.value = _state.value.copy( | ||
| name = trimmedName, | ||
| drawLineColor = Grey500, | ||
| helper = HELPER, | ||
| helperIcon = null, | ||
| helperColor = Grey400, | ||
| isButtonValid = false | ||
| ) | ||
|
|
||
| else -> _state.value = _state.value.copy( | ||
| name = trimmedName, | ||
| drawLineColor = TerningMain, | ||
| helper = HELPER_AVAILABLE, | ||
| helperIcon = R.drawable.ic_sign_up_available, | ||
| helperColor = TerningMain, | ||
| isButtonValid = true | ||
| ) |
There was a problem hiding this comment.
이렇게 한번에 관리하니까 직관적이네요 ㅜ ㅜ 🥹
boiledEgg-s
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
나중에 리컴포지션에 대한 리팩토링을 하게 된다면, 뷰모델에서 텍스트를 관리하는 것보단 스크린 자체에서 관리를 하는 방향의 수정을 시도해봐도 좋을 것 같아요!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240711_071321_Terning-Android.mp4
📢 To Reviewers