[UI/#52] 홈 뷰 / 컴포넌트 적용 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arinming
approved these changes
Jul 12, 2024
boiledEgg-s
approved these changes
Jul 12, 2024
| modifier | ||
| .background(White) | ||
| .width(140.dp) | ||
| ScrapBox( |
Comment on lines
+154
to
+176
| items(itemCount) { | ||
| Box( | ||
| modifier = modifier | ||
| .height(92.dp) | ||
| .padding(horizontal = 24.dp) | ||
| .customShadow( | ||
| color = Grey200, | ||
| shadowRadius = 10.dp, | ||
| shadowWidth = 2.dp | ||
| ) | ||
| .background( | ||
| color = White, | ||
| shape = RoundedCornerShape(10.dp) | ||
| ) | ||
| ) { | ||
| InternItem( | ||
| imageUrl = "https://reqres.in/img/faces/7-image.jpg", | ||
| title = "[Someone] 콘텐츠 마케터 대학생 인턴 채용", | ||
| dateDeadline = "2", | ||
| workingPeriod = "2", | ||
| isScraped = false, | ||
| ) | ||
| } |
There was a problem hiding this comment.
이 부분을 특별히 Box로 감싸신 이유가 있나요??
혹시 커스텀 섀도우가 적용되지 않아서 그런거라면 InternItem 로직을 수정하면 됩니다!!
There was a problem hiding this comment.
커스텀 섀도우가 적용했더니 외곽부분 뿐만 아니라 InternItem 안에 있는 Text나 이미지에도 섀도우가 적용이 돼서 Box로 감싸고 거기에 섀도우를 적용해서 InternItem 내부에는 섀도우가 적용되지 않도록 했습니다..!!
leeeyubin
approved these changes
Jul 12, 2024
Comment on lines
+154
to
+160
| items(itemCount) { | ||
| Box( | ||
| modifier = modifier | ||
| .height(92.dp) | ||
| .padding(horizontal = 24.dp) | ||
| .customShadow( | ||
| color = Grey200, |
Comment on lines
27
to
+29
| .height(116.dp) | ||
| .border( | ||
| width = 1.dp, | ||
| color = Grey150, | ||
| RoundedCornerShape(5.dp), | ||
| ), | ||
| verticalAlignment = Alignment.Bottom | ||
| ) { | ||
| Box( | ||
| modifier | ||
| .background( | ||
| color = Grey500, | ||
| shape = RoundedCornerShape( | ||
| topStart = 5.dp, | ||
| bottomStart = 5.dp | ||
| ) | ||
| .width(140.dp), | ||
| cornerRadius = 5.dp, |
There was a problem hiding this comment.
이거 홈 뷰에서 오늘 마감되는 공고 부분에 사용되는 아이템입니다!!
Comment on lines
40
to
44
| text = title, | ||
| modifier = modifier | ||
| .padding(start = 8.dp, end = 9.dp, bottom = 8.dp), | ||
| style = TerningTheme.typography.button3, | ||
| color = Black, |
|
고정 dp 준거는 내부 컴포넌트 수정이 필요해서 컴포넌트 머지한 후에 수정하도록 하겠습니다!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240712_063425_Terning-Android.mp4
📢 To Reviewers