Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/#57] 색상 팔레트 #58

Merged
merged 6 commits into from
Jul 12, 2024
Merged

[UI/#57] 색상 팔레트 #58

merged 6 commits into from
Jul 12, 2024

Conversation

boiledEgg-s
Copy link
Member

⛳️ Work Description

  • 라디오버튼 그룹 컴포넌트화
  • 색상 팔레트 구현

📸 Screenshot

default.mp4

📢 To Reviewers

  • 라디오버튼 그룹을 컴포넌트화 했습니다.
  • 프로필 설정할 때 이미지 선택하는 라디오버튼에서 제 컴포넌트 사용하시면 코드가 더 깔끔해지지 않을까 싶습니다!!
  • 크기 관련해선 리뷰 받고 수정할게요!!

Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

색상 팔레트 뚝딱 만들어주는 형님 짱 ㅠ

options = colorList,
gridCellCount = 5,
onOptionSelected = { color ->
Log.d("CalendarScreen","color: ${colorList.indexOf(color)}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그있음도!

Comment on lines 84 to 87
Icon(
imageVector = Icons.Outlined.Check,
tint = Color.White,
contentDescription = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons.Outlined.Check 지우고 피그마에 있는 아이콘으로 바꿔주세욤!
tint에도 터닝 테마로 지정 부탁드림ㄷㅇ

Comment on lines 32 to 33
modifier = modifier
//.padding(horizontal = 42.dp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 주석처리는 오 ㅐ하신건가여?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실수임다!

Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

색상팔레트 만들어주는 형님 진짜 최고다

Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

석준오빠 최~~고!!!

Comment on lines +46 to +50
RadioButtonGroups(
modifier = modifier.size(251.dp, 84.dp),
options = colorList,
gridCellCount = 5,
onOptionSelected = { color ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

named argument!! 해주세용
그리구 251은,,어디서 쓰이는 걸까여,,,?!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 나중에 아린이가 다이얼로그 만들 때 유동적으로 수정하면 될 거 같아요!

@boiledEgg-s boiledEgg-s merged commit 868d9f7 into develop Jul 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 💐 UI 작업 석준💜 석준
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] 색상 팔레트
4 participants