[UI/#42] 공고 뷰 / 공고 상세 페이지 구현 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # feature/src/main/java/com/terning/feature/main/MainNavigator.kt # feature/src/main/java/com/terning/feature/main/MainScreen.kt # feature/src/main/res/values/strings.xml
# Conflicts: # feature/src/main/res/values/strings.xml
Closed
6 tasks
leeeyubin
approved these changes
Jul 12, 2024
Comment on lines
93
to
95
| item { | ||
| val decimal = DecimalFormat("#,###") | ||
|
|
There was a problem hiding this comment.
오홍 신기하네요! "#,###"는 상수로 둬도 될 것 같아요!
Comment on lines
178
to
182
| } | ||
| } | ||
|
|
||
|
|
||
| Column( |
Comment on lines
45
to
47
| modifier = Modifier | ||
| .width(60.dp) | ||
| .height(60.dp) |
There was a problem hiding this comment.
요기두 aspectRatio로 둘 수 있을 듯??!!
Comment on lines
28
to
30
|
|
||
| @Serializable | ||
| data object Intern : MainTabRoute |
There was a problem hiding this comment.
바텀바 없는 스크린 맞죠...? 그럼 Route로 해주세요!
There was a problem hiding this comment.
아맞다.........................바보
Hyobeen-Park
approved these changes
Jul 12, 2024
boiledeggg
approved these changes
Jul 12, 2024
| tint = if (isScrap) TerningMain else Grey350 | ||
| ) | ||
| Text( | ||
| text = "${viewCount}회", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
42.mp4
📢 To Reviewers