[UI/#60] 홈 뷰 / 홈 뷰 기본 UI 로직 구현 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # feature/src/main/java/com/terning/feature/home/home/HomeRoute.kt
boiledeggg
approved these changes
Jul 12, 2024
Comment on lines
67
to
68
| val userScrapState = viewModel.scrapData.collectAsState() | ||
| val recommendInternData = viewModel.recommendInternData.collectAsState() |
There was a problem hiding this comment.
collectAsStateWithLifecycle을 쓰자고 리더님께서 댓글을 다시기 전에 제가 답니다ㅎ
There was a problem hiding this comment.
그리고 상태 값 할당을 = 대신 by로 하면 참조할 때 .value()를 쓰지 않아도 된답니다~
There was a problem hiding this comment.
오호 찾아보니 collectAsStateWithLifecycle이 더 안정적인 것 같네요..!! 감사합니다!!
| private val _userName by mutableStateOf<UserNameState>( | ||
| UserNameState( | ||
| userName = "남지우자랑스러운티엘이되", | ||
| internFilter = listOf(4, 1, 2024, 8) |
There was a problem hiding this comment.
이런 부분도 데이터클래스로 관리하는 편이 좋을 것 같아요!!
|
|
||
| if (userNameState.internFilter != null && recommendInternData.value != null) { | ||
| items(recommendInternData.value!!.size) { index -> | ||
| ShowRecommendIntern(recommendInternData.value!![index]) |
arinming
approved these changes
Jul 12, 2024
| text = stringResource( | ||
| id = R.string.home_today_title, | ||
| if (userNameState.userName.length in 7..12) "\n" + userNameState.userName |
There was a problem hiding this comment.
이거 7..12 상수로 빼면 좋겠네요~
leeeyubin
approved these changes
Jul 13, 2024
|
|
||
| if (userNameState.internFilter != null && recommendInternData.value != null) { | ||
| items(recommendInternData.value!!.size) { index -> | ||
| ShowRecommendIntern(recommendInternData.value!![index]) |
Comment on lines
+195
to
+197
| .padding(top = 9.dp) | ||
| .padding(horizontal = 24.dp), |
There was a problem hiding this comment.
Suggested change
| modifier = Modifier | |
| .padding(top = 9.dp) | |
| .padding(horizontal = 24.dp), | |
| modifier = Modifier | |
| .padding(top = 9.dp, horizontal = 24.dp) |
이렇게도 가능할 것 같네요..!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240713_041200_Terning-Android.mp4
📢 To Reviewers