[ADD/#6] Design System 기초세팅 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arinming
approved these changes
Jul 5, 2024
| @@ -4,7 +4,7 @@ import android.os.Bundle | |||
| import androidx.activity.ComponentActivity | |||
| import androidx.activity.compose.setContent | |||
| import androidx.activity.enableEdgeToEdge | |||
| import com.terning.core.ui.theme.TerningAndroidTheme | |||
| import com.terning.core.designsystem.theme.TerningAndroidTheme | |||
There was a problem hiding this comment.
TerningAndroidTheme가 어디있는 걸까용..!?!
There was a problem hiding this comment.
이 부분이 TerningTheme으로 수정돼야 하는거 아닌가요?!
There was a problem hiding this comment.
어라리요..? 어쩌다 이렇게 됐는지 모르겠지만 수정했습니다😅
boiledEgg-s
reviewed
Jul 5, 2024
| @@ -4,7 +4,7 @@ import android.os.Bundle | |||
| import androidx.activity.ComponentActivity | |||
| import androidx.activity.compose.setContent | |||
| import androidx.activity.enableEdgeToEdge | |||
| import com.terning.core.ui.theme.TerningAndroidTheme | |||
| import com.terning.core.designsystem.theme.TerningAndroidTheme | |||
There was a problem hiding this comment.
이 부분이 TerningTheme으로 수정돼야 하는거 아닌가요?!
leeeyubin
approved these changes
Jul 5, 2024
Comment on lines
+1
to
+2
| package com.terning.core.designsystem.theme | ||
|
|
| @@ -4,7 +4,7 @@ import android.os.Bundle | |||
| import androidx.activity.ComponentActivity | |||
| import androidx.activity.compose.setContent | |||
| import androidx.activity.enableEdgeToEdge | |||
| import com.terning.core.ui.theme.TerningAndroidTheme | |||
| import com.terning.core.designsystem.theme.TerningAndroidTheme | |||
Comment on lines
+16
to
+20
| val PretendardSemiBold = FontFamily(Font(R.font.pretendard_semibold)) | ||
| val PretendardMedium = FontFamily(Font(R.font.pretendard_medium)) | ||
| val PretendardRegular = FontFamily(Font(R.font.pretendard_regular)) | ||
| val PretendardLight = FontFamily(Font(R.font.pretendard_light)) | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📢 To Reviewers
TerningMainTerningTheme.typography.이름이렇게 사용하면 됩니다!!